New filetype icons #1124
New filetype icons #1124
Conversation
|
Hi @Kernald! The bug that you detected is fixed in the PR #1114, this is in our QA process. I think it is your first contribution, is it? In that case before to merge your PR in the master branch, we need that you will send a signed copy of the contributor agreement here http://owncloud.org/about/contributor-agreement/ to @karlitschek. Thanks for your contribution |
|
It's not my first and I already signed and sent the agreement a while ago. I can re-send it if needed. Regarding the fix, should I remove the second commit and only keep in this branch the one regarding the icons? |
|
Ok, if you signed the agreement and in the past you do not need to do it again. Sorry, I didn't see you in the controibutors list. Regarding the fix, if you want to remove the commit you can, if you'd rather leave it before merging this PR it would be updated with the new master content. As you want. On the other hand, I have been reviewing the images you've added. We need to have the images in the resolutions: mdpi, hdpi, xhdpi and xxhdpi. Those are the most important densities right now. Mdpi is the baseline density, and I didn't see those images updated. |
|
Sorry you're right, I forgot to update the mdpi ones. I'll do it tonight, and remove the added ldpi images. |
|
I just updated the branch:
|
|
Wow, looks great! :) Check it out @AndyScherzinger @tobiasKaminsky @stoyicker The only thing is, as you already mentioned, the checkerboard background for the folder and PDF icon. |
|
Hi @Kernald, thanks for your quickly update :) So, PR ready for testing. @purigarcia |
|
@masensio did you fix the checkerboard pattern bug? If I remember correctly, you just removed that from the file list again, right? :) |
|
@jancborchardt It has been fixed in #1114 by removing the checkerboard in file list (keeping it in images background only). |
|
@jancborchardt, as @Kernald said, it is fix in the PR #1114. #1114 is merged into master now :) |
|
Nice work! This gets us closer to a consistent oC look&feel but also adds to the material design :) |
|
@AndyScherzinger yeah, I also though this fits very nicely with the Material design. :) high five! |
|
@jancborchardt yeah! For having it, I locally pulled it into my FAB branch :) - Looks good for xxhdpi 😃 |
|
PR in master branch. |
|
👍 @Kernald - material design is progressing :) |
|
Great stuff! :) When will we have a Material design release of the Android app btw? @rperezb @davitol @MTRichards? |
|
We should at least integrate #1090 inho since:
One thing to keep in mind is that the master already contains the new icons and thus visually matches oC 8.2 web, so maybe the releases could be around the same time. One bug might still be in there somewhere as mentioned in #1090 but I couldn't find @tobiasKaminsky's comment anymore, so I am waiting for his reply to go on a bug hunt :) Besides: Any input on the #1100, having the fab in this release would make the material release a big bang style wise 💃 but we can postpone that if we want to. |
|
@Kernald I created a new branch for the further icon work: https://github.com/owncloud/android/tree/new_filetype_icons - if you direct your next PR with the further icon work to this branch I can just merge it, do the coding and send a feature complete PR 😃 |
|
@AndyScherzinger . what future icon work? @jancborchardt , next release, with MD stuff already merged, is programmed for mid-september. You can check the milestone: https://github.com/owncloud/android/milestones But probably we'll need to review the date, with the current state I don't feel we're going to get it. @ALL, could we limit the discussions in merged PRs / closed issues? There are enough open issues to continue. Thanks,. |
|
@davivel the screenshot of oC web @jancborchardt has posted shows two more icons (a gear and a code icon, see #1118) which are being used in the oC 8.2 web app and thus imho should also be used in the mobile app for visual consistency. |
|
@AndyScherzinger @Kernald @davivel there’s also zip files etc – make sure all the filetypes are properly represented. ;) https://github.com/owncloud/core/tree/master/core/img/filetypes |
|
The zip files are properly represented already :) |
|
OK, thanks. Let's follow in #1118 then. |
|
Hey @AndyScherzinger @tobiasKaminsky - I know this is off topic, but... |
|
Hey @MTRichards, In case I would do a write up what would be the desired file format? (I most likely will include several, external links to google design and other blog posts, if that is okay :) |
|
I understand, time constraints being what they are - not a problem. We also take short, long or in the middle - up to you and your time. Any format that works for you is fine. We will probably turn it into a blog on our .org site then, and reference that in other posts. |
|
@jospoortvliet @MTRichards I will try to write a post this saturday. Any input on the content? I would write about the material design obviously and would most likely focus on the development aspects behind this... besides mentioning the visual things that changed and would also like to write a couple of lines motivating other to join the development of the app and the eco system in general since I am enjoying this great experience with everyone here in the community and also the quite low entrance barrier to contribute to this project. So this last issue would also be something it would like to mention :) Blog post on .org sound absolutely fine to me 👍 |
|
@AndyScherzinger cool stuff! :) Would be good to collaborate with @tobiasKaminsky to get a joint blog post out. :) Or maybe @tobiasKaminsky you want to focus on a different topic in a separate blog post? We can definitely make this a more regular thing and not just a one-off, maybe @Kernald or @stoyicker also want to blog in the future? :) |
|
@jancborchardt Why not, I already maintain a blog, I'm pretty sure I could have posts interresting for the OwnCloud community! |
All of that sounds great, go for it! |
|
@jancborchardt Unfortunately for me, it is long that I can barely find time to commit to open source projects and, as you may have noticed, even less to ownCloud, so blogging in the long-term future is not a thing for me. However, should this be demanded, I could possibly write about the great experience that it has been as a "farewell". |
|
@AndyScherzinger and everybody else - write a bit about your view on things. How it was, what was hard, what was fun, what was easy, anything. And what you did etc. Don't worry about spelling, grammar and so on - or format, any format is OK. Well, try not to send my binaries or utf 9.3 (?), but flat text or odt or markdown or html is all fine. ;-) I'll be more than happy to put it in a nice looking blog post for .org. mail my at jos @ the owncloud.com server pls. Great work, all! |
|
@jospoortvliet You got mail! :) |
|
I've seen it and I'll make sure we have a nice blog by the time we get the new Android client out. Unfortunately I'm very busy at the moment but it will come ;-) |
|
@MTRichards Sorry, but I am currently to busy to write a blog. |
|
Ok, no problem. Just didn't want you to be left out. We will ask again! |
|
@tobiasKaminsky we've got a nice blog now, with text from @AndyScherzinger (who wrote an epic overview of what's new with material design) and thoughts from @stoyicker as well. So we're good. For next time, yeah, it'd be great if you could share something of course. Note that I don't need much - just a brain dump, raw thoughts with some links and I'm happy to turn them in something pretty! |
This uses the icons referenced in #1118 . As mentioned in this issue, the ldpi variant has been scaled down to 3232px (from 3636px) to keep a multiple of 16px.
Here's the result, on an xhdpi screen:
While testing this, I also noticed an issue on the file list adapter: checker background was added on PNG items, but the background wasn't reset on other items. This is visible on the screenshot above on the folder and the PDF file (I fixed this after I took the screenshot).