Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toolbar instead of actionbar where applicable #1556

Closed
AndyScherzinger opened this issue Mar 22, 2016 · 3 comments
Closed

Use toolbar instead of actionbar where applicable #1556

AndyScherzinger opened this issue Mar 22, 2016 · 3 comments
Assignees
Milestone

Comments

@AndyScherzinger
Copy link
Contributor

Like the title says use the toolbar - Google's new, to be used implementation of the top bar instead of the action bar which can be considered legacy.

Motivation
The actionbar is simply a bar which can have a menu, search widget and in newer AppCompat versions also a drawer implementation but isn't as flexible as the toolbar.

Reasons and benefits
The toolbar can be customized on many ways like but not limited to:

  • adding any kind of views to it, like the progressbar which would be nice especially when
    • we integrate the multi select branch (no dark blue line below the then grey bar)
    • no dark blue line below the bar when the drawer is opened
  • animate it, like scrolling it away on a list/recycler view which seems nice on the file browsing views
  • the material drawer can be full height, like mentioned in Full-height material drawer? #1210 because this is only possible for the toolbar not the action bar (it can be done with hacks though)

I would like to work on this in case we agree this is worth implementing which I strongly suggest to make the bar future proof and also to be able to implement the above mentioned gimmicks.

So pinging @davivel @jancborchardt @malkomich @tobiasKaminsky and @przybylski for feedback on this matter.

@davivel
Copy link
Contributor

davivel commented Apr 19, 2016

Great job here, and great presentation, @AndyScherzinger .

Just missed a section about "drawbacks" ;)

@davivel
Copy link
Contributor

davivel commented Oct 18, 2016

Merged, will be released with version 2.2.0

@davivel davivel closed this as completed Oct 18, 2016
@davivel davivel added this to the 2.2.0 milestone Oct 18, 2016
@AndyScherzinger
Copy link
Contributor Author

🛩️ Awesome collab! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants