Background color should be white everywhere

[jancborchardt]

The background color of the Settings and Log sections is not white at the moment. But should be, exactly like in the file list etc.

The background should be white everywhere, except black in the image view of course. :)

[tobiasKaminsky]

@AndyScherzinger maybe you can do this? As you are into the whole design in the app?

[AndyScherzinger]

Sure thing! Have to check when I find the time since the day job is keeping me quite busy these days. I'll see what I can do.

[masensio]

Hi @ALL,

at the moment, this color is not specifically defined for Log and Settings section but by default it is white. Maybe it is better to specity in the xml layout for these sections to update background color with a minimum changes in code.

[AndyScherzinger]

Hmmmm, just checked the and it is also white on my phone (latest master), but yes I guess simply adding this to the two layouts is probably the quickest and safest ways to do this.

[AndyScherzinger]

@masensio my mistake the background isn't white as in #FFFFFF at the moment it is #FAFAFA while the background of the list really is #FFFFFF colored.

[AndyScherzinger]

@masensio the best and most technically accurate way would be via the theme :)

simply add the following line:
<item name="android:windowBackground">@color/white</item>

to the style.xml for the general theme definitions:

• Theme.ownCloud
• Theme.ownCloud.noActionBar

....and then you are done and it'll work on any (future) activity 😃

I can also do a PR for this if you want me to :)

[masensio]

@AndyScherzinger
I've search "#FAFAFA" color in the whole project and I have found 0 occurrences. At the moment, we are using #FFFFFF for background color.

On the other hand, to use the theme to define the background color is ok, but it is better to use the background_color instead of white, and give the proper value to background_color.

For Settings View, I don't know if it is enough to use theming to define the background color, we need to take into account that it is an special activity.

[AndyScherzinger]

Yes, since I tested it locally before posting this :) - I even made the screenshots and checkd the color with a picker...

You won't find #FAFAFA - This is due to the fact that is is the default android background color set by the theme (in style.xml) we adopt (parent="..."). So you won't find any reference in our code base since it is inherited.

[AndyScherzinger]

@jancborchardt and @davivel just fyi this has been fixed on the reliable uploads branch, so I tagged it with 1.9.2 😃

[davivel]

True. Thanks, @AndyScherzinger .

Ready to release -> close

[AndyScherzinger]

Nice! As always happy to help and be a part of it :)