Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use permalinks in activities #521

Closed
wants to merge 2 commits into from
Closed

Use permalinks in activities #521

wants to merge 2 commits into from

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented May 6, 2016 •
edited
Loading

  • REQUIRES: permalinks in core Permalinks core#24434
  • TODO: fix unit tests
  • TODO: trashbin cases ? (might be a job for core...)
  • TEST: all three cases, especially the one with "getInfoByPath" where we get the fileid from $info

Are there other cases I forgot ?

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @nickvergessen and @DeepDiver1975 to be potential reviewers

@PVince81 PVince81 mentioned this pull request May 6, 2016
Closed
@nickvergessen
Copy link
Contributor

Well since it doesn't work for trashbin and the old way does, I'd say we shouldn't do that atm:
owncloud/core#24434 (comment)

@PVince81 PVince81 mentioned this pull request May 10, 2016
Merged
@PVince81
Copy link
Contributor Author

PVince81 commented May 10, 2016 •
edited
Loading

@nickvergessen nickvergessen added this to the 9.2-next milestone May 24, 2016
@PVince81 PVince81 modified the milestones: backlog, 10.0 Apr 6, 2017
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 4, 2017

doesn't work, needs rework, no time

@PVince81 PVince81 closed this Jul 4, 2017
@PVince81 PVince81 deleted the use-permalinks branch July 4, 2017 14:41
@PVince81 PVince81 restored the use-permalinks branch June 18, 2018 14:44
@PVince81 PVince81 reopened this Jun 18, 2018
@PVince81 PVince81 modified the milestones: maybe some day, backlog Jun 18, 2018
@PVince81
Copy link
Contributor Author

rebased

@PVince81
Copy link
Contributor Author

not a priority currently and there are technical challenges that will take longer to solve.
activity app concept needs to be rethought on a higher level

@PVince81 PVince81 closed this Feb 15, 2019
@PVince81 PVince81 deleted the use-permalinks branch February 15, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1 - To develop
Projects
None yet
Milestone
backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@PVince81 @mention-bot @nickvergessen