Drop PHP 7.2 #1003
Merged
Drop PHP 7.2 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
drop-php-7.2
branch
from
548d774 to
29ca149
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
phil-davis
requested review from
dpakach,
jasson99,
JammingBen and
AlexAndBear
JammingBen
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of owncloud/core#39134
Similar to core PR owncloud/core#38697
This app should still run fine on ownCloud core 10.8.0. But all installations are recommended to use PHP 7.4 nowadays anyway. (And some might be on PHP 7.3, which should be OK). So the recommended configuration would be ownCloud core 10.8.0 with PHP 7.4. And the oC10 apps all work fine with that.