This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
Update timestamp of locationprovider #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the possibility to support timestamps with and without milliseconds as well as textual datetime descriptions. This is needed as different clients use different formats and with this they don't need different parameters. For example Osmand uses timestamps with milliseconds and GPSLogger uses textual datetime descriptions. Before Osmand was not working like it was said here: owncloud-archive#3 (comment)
Don't know where they came from...
|
@brantje are you okay with this change? |
| @@ -44,7 +44,15 @@ public function update() { | |||
| $params = array('user' => $this -> userId); | |||
| $location['lat'] = $this->params('lat'); | |||
| $location['lng'] = $this->params('lon'); | |||
| $location['timestamp'] = strtotime($this->params('timestamp')); | |||
| if(((string)(float)$this->params('timestamp') === $this->params('timestamp'))) { | |||
There was a problem hiding this comment.
I'd add unit tests to this - just saying 🙊
brantje
added a commit
that referenced
this pull request
Jun 25, 2015
Update timestamp of locationprovider
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to support timestamps with and without milliseconds as well as textual datetime descriptions.
This is needed as different clients use different formats and with this they don't need different parameters.
For example Osmand uses timestamps with milliseconds and GPSLogger uses textual datetime descriptions.
Before Osmand was not working like it was said here:
#3 (comment)