Infinite scrolling for gallery + seamless layout #28
Conversation
|
@icewind1991 would have been cooler to have it split up in several commits to actually see what has been done. ;) Also, to have @jbtbnl’s commits separate for proper credit. |
|
Yeah, too bad that my code wasn't used. Anyway, good luck with it 😉 |
|
@jbtbnl are you ok with the layout though, is it what you had in mind as well? |
|
@jancborchardt the design is basically the same but there are a few issues with the implementation of @icewind1991:
Also the preview images are loading way to slow (same issue in my branch as well). |
|
|
Added support for window resizing, fixed centering of captions and improved performance by loading thumbnails in parallel. I think this is ready for testing (cc @jancborchardt @PVince81 @karlitschek @DeepDiver1975) @jbtbnl Not sure what you mean with "the last row contains more images then visible" and "horizontal scaling doesn't work properly" |
|
|
Otherwise: Works and looks great. |
|
Another one:
|
|
@LukasReschke fixed the issues, thanks for testing |
icewind1991
changed the title
|
I do have another problem with large panoramic photos. Some photos are still not shown since the images are too wide for the row. Files: Gallery view: The images used in this album are downloadable here until 01.06.2014: https://cloud.statuscode.ch/public.php?service=files&t=48ab5132bd4d002605398c7950562992 |
|
Also the public share view seems not to work |
|
@icewind1991 the screenshots of @LukasReschke show what I meant with
|
|
Gnah. Sorry, public download doesn't work anymore since I somehow triggered a bug in core that leads to file loss :-/ Trying to reproduce.... |
|
Fixed the issue with very wide images, also limited the aspect ratio of thumbnails to 3:1 |
|
Works after clearing the previews. Thanks a lot. I'll look into sharing. |
WIthout this images in subdirectories won't be properly resolved in the public view
|
Sharing should now work properly in subfolders, @icewind1991 can you please review my commits? |
|
@LukasReschke changes look good |
|
The outline stuff looks quite strange. I needed to double check if it was a glitch or something. What would be better is simply 2px separation between everything. 2px to the side and the top, 2px between every image, and 2px between each row. It needs to be 2 px everywhere to look consistent – it can vary at the right though. |
|
I mean 4px, not 2px. :) |
|
I don't like having "whitespace" between the images, especially on mobile I think a seamless layout looks better |
|
It makes the pictures blend together. You don’t know where one picture ends and the other continues. Especially when they are similar, this is jarring. This is not about personal preference after all ;) There’s a reason why Flickr and Dropbox and others have slight space between the pictures. It helps you tell them apart. |
|
Three other bugs:
Regarding the whitespace: The little black border is already enough for me. I can easily distinguish the pictures. |
@LukasReschke fix is here: https://github.com/owncloud/gallery/pull/17/files#diff-721c4fdccbf9e7c9a389daf09b558bfcL378 |
|
@jbtbnl Could you please commit this to this branch? That would be great! |
|
@LukasReschke it seems the fix is already present: https://github.com/owncloud/gallery/pull/28/files#diff-721c4fdccbf9e7c9a389daf09b558bfcL375 Not sure why your issue still exists... |
|
Nice, looking way better now! Thank you @jbtbnl @icewind1991! :) We can fix all the other issues after this, we need to take care not to make pull requests too big. 👍 |
Infinite scrolling for gallery + seamless layout
|
@icewind1991 now to fixing the way folders are displayed ;) |
This is a work in progress of @icewind1991 regarding owncloud/gallery#5 and a successor of my seamless layout in owncloud/gallery#17