Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

add note re using redis with file locking app #1182

Closed
wants to merge 1 commit into from
Closed

add note re using redis with file locking app #1182

wants to merge 1 commit into from

Conversation

carlaschroder
Copy link
Contributor

No description provided.

@carlaschroder
Copy link
Contributor Author

Please review @LukasReschke @butonic
re: owncloud/core#11804

This was referenced Jun 2, 2015
Closed
Closed
@MorrisJobke
Copy link
Contributor

👍

PVince81
PVince81 reviewed Jun 3, 2015
View reviewed changes
admin_manual/configuration_files/files_locking_enabling.rst
``config.php`` file, like this example::

'memcache.local' => '\OC\Memcache\redis',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace \ with double backslashes \\ (it was wrong in the sample config, fixed now)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't matter as long as the character following the \ doesn't have a special escaped meaning

@PVince81
Copy link
Contributor

PVince81 commented Jun 3, 2015

@carlaschroder I'd say we should move the "Experimental file locking" to a separate section page and add a paragraph to clarify that it's not the same as the files locking app.

Also please add a hint regarding enabling the PHP redis module additionally to the config.php settings, as it's easy to miss (like we did here owncloud/core#16696 (comment))

Thanks.

@PVince81 PVince81 mentioned this pull request Jun 3, 2015
Closed
@carlaschroder
Copy link
Contributor Author

Well this is just a wee tiny difference. OK then thanks @PVince81!

@carlaschroder carlaschroder deleted the lockingredis branch June 3, 2015 16:58
@carlaschroder
Copy link
Contributor Author

Please review new page #1186

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlaschroder @MorrisJobke @PVince81 @LukasReschke @icewind1991