fix caldav when the calendar app is only enabled for specific groups #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schiesbn @DeepDiver1975 can you test this, together with owncloud/core#9962 |
|
@ben-denham @ockham @babelouest can you please review this one? |
|
Sorry, I know too little about this to be qualified to review. |
|
@icewind1991 , I understand the first change, but what does the second has to do with this bug ? Is it another way of detecting if the app contact is enabled ? |
|
Yes, it checks if the app is enabled after webdav auth is done |
icewind1991
force-pushed
the
app-group-enable-remote
branch
from
a5909d6
to
1fd2f64
Compare
|
Works in combination with #9962 👍 |
icewind1991
force-pushed
the
app-group-enable-remote
branch
from
1fd2f64
to
abac66f
Compare
|
The inspection completed: No new issues |
|
Works 👍 |
LukasReschke
added a commit
that referenced
this pull request
Nov 18, 2014
fix caldav when the calendar app is only enabled for specific groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since checking if an app is enabled requires a user to be logged in we need to postpone those checks until after the *DAV auth is handled.
Requires owncloud/core#9962