Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST Unit test for nb_nll #75

Merged
merged 9 commits into from
Feb 14, 2023
Merged

TST Unit test for nb_nll #75

merged 9 commits into from
Feb 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2023

Reference Issue or PRs

What does your PR implement? Be specific.

  1. Improvement of the docstrings of the utils.nb_nll function (maths equations, reference)
  2. Adds a unit test to check that the implicit probabilities computed by the function provide the correct moments (which is necessary to achieve a correct implementation, but not sufficient)

@ghost ghost requested a review from BorisMuzellec February 10, 2023 17:05
@ghost ghost marked this pull request as ready for review February 10, 2023 17:17
@ghost ghost added the testing label Feb 10, 2023
@ghost ghost changed the title [QA] Unit tests for nb_nll [QA] Unit test for nb_nll Feb 10, 2023
@BorisMuzellec BorisMuzellec changed the title [QA] Unit test for nb_nll TST Unit test for nb_nll Feb 13, 2023
@BorisMuzellec
Copy link
Collaborator

Hi @mandreux-owkin, thanks for this PR! It's a good idea to clarify what this function does indeed.

There is a little rendering bug with the current docstring (cf below), could you have a look at it when you have time?

Capture d’écran 2023-02-13 à 11 39 34

pydeseq2/utils.py Outdated Show resolved Hide resolved
pydeseq2/utils.py Outdated Show resolved Hide resolved
pydeseq2/utils.py Outdated Show resolved Hide resolved
mandreux-owkin and others added 5 commits February 14, 2023 13:50
@ghost
Copy link
Author

ghost commented Feb 14, 2023

Thanks @BorisMuzellec for your review!

There is a little rendering bug with the current docstring (cf below), could you have a look at it when you have time?

Well spotted, thanks, it's fixed. I also changed the values of the tests to make them much faster.

Can you please review again?

@ghost ghost requested a review from BorisMuzellec February 14, 2023 12:54
Copy link
Collaborator

@BorisMuzellec BorisMuzellec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BorisMuzellec BorisMuzellec merged commit c52e9d5 into main Feb 14, 2023
@BorisMuzellec BorisMuzellec deleted the maa/unit-test-nb-nll branch February 14, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants