Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC add mybinder to examples #55

Merged
merged 9 commits into from
Jan 20, 2023
Merged

DOC add mybinder to examples #55

merged 9 commits into from
Jan 20, 2023

Conversation

maikia
Copy link
Collaborator

@maikia maikia commented Jan 19, 2023

Adds mybinder button to the examples in the docs

image

@maikia maikia changed the title DOC and mybinder to examples DOC add mybinder to examples Jan 19, 2023
@maikia maikia marked this pull request as ready for review January 19, 2023 12:03
setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@BorisMuzellec BorisMuzellec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @maikia! I just tested the link on mybinder, it runs fine.

There is a minor issue though with the way "Note" boxes are rendered in mybinder (c.f. the screenshot), could you check what's going on if you have time?

Capture d’écran 2023-01-19 à 15 12 13

Otherwise, LGTM!

@maikia
Copy link
Collaborator Author

maikia commented Jan 20, 2023

Thanks @BorisMuzellec for your review. Notes now render alright (it was an issue with indentation):
image

@maikia maikia merged commit c703cd1 into main Jan 20, 2023
@maikia maikia deleted the mybinder branch January 20, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants