Index sorting #30
Merged
Index sorting #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisMuzellec
force-pushed
the
fix/index_ordering
branch
from
aa2da12
to
2d7ce6e
Compare
maikia
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Thanks for your contribution @BorisMuzellec ;-p
This is already great, if you want to make it even better you can also check if the correct error message is raised with the error to ensure we are not just raising any keyerror but feel free to merge as is
BorisMuzellec
commented
Jan 5, 2023
|
Thanks @maikia and @arthurPignetOwkin ! I'll merge then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that appears when the count matrix and the clinical data provided to a
DeseqDataSethave identical sets of samples, but in a different order, by sorting the indices at initialization.