Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

summary function uses quiet to print #286

Merged
merged 1 commit into from
Jun 10, 2024
Merged

summary function uses quiet to print #286

merged 1 commit into from
Jun 10, 2024

Conversation

yihming
Copy link
Contributor

@yihming yihming commented Jun 6, 2024

Reference Issue or PRs

What does your PR implement? Be specific.

Make DeseqStats.summary() function also rely on quiet parameter for verbose.

@yihming yihming requested a review from a user June 6, 2024 01:43
umarteauowkin
umarteauowkin approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@umarteauowkin umarteauowkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spotting this ! If the checks pass, ready to merge.

@umarteauowkin umarteauowkin merged commit 8c2ae49 into owkin:main Jun 10, 2024
10 checks passed
@yihming yihming deleted the yiming branch June 13, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umarteauowkin umarteauowkin umarteauowkin approved these changes

@BorisMuzellec BorisMuzellec Awaiting requested review from BorisMuzellec BorisMuzellec is a code owner

@maikia maikia Awaiting requested review from maikia maikia is a code owner

@arthurPignetOwkin arthurPignetOwkin Awaiting requested review from arthurPignetOwkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihming @umarteauowkin