Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace np.NaN with np.nan -> numpy 2.0 compat #282

Merged
merged 1 commit into from
May 27, 2024
Merged

Replace np.NaN with np.nan -> numpy 2.0 compat #282

merged 1 commit into from
May 27, 2024

Conversation

Zethson
Copy link
Contributor

@Zethson Zethson commented May 25, 2024

What does your PR implement? Be specific.

Our pre-release complains about:

E AttributeError: np.NaN was removed in the NumPy 2.0 release. Use np.nan instead.

Copy link
Collaborator

@BorisMuzellec BorisMuzellec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Zethson

@BorisMuzellec BorisMuzellec merged commit 594691f into owkin:main May 27, 2024
10 checks passed
@abearab
Copy link

abearab commented Jun 24, 2024

@BorisMuzellec I have v0.4.9 installed but I still face this issue. Is it still pending to be released as a new version?

@valentinadiproietto
Copy link

valentinadiproietto commented Jul 16, 2024

@BorisMuzellec, same for me, I have I have v0.4.9 installed but I still face this issue, but @abearab v0.4.10 solves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants