Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG dispersion prior variance #105

Merged
merged 2 commits into from
Mar 28, 2023
Merged

BUG dispersion prior variance #105

merged 2 commits into from
Mar 28, 2023

Conversation

mikelove
Copy link
Contributor

In the dispersion prior variance step, the expected variance of the log dispersion involves a function of (m - p), number of samples minus number of columns of model matrix. Compare to:

https://github.com/mikelove/DESeq2/blob/devel/R/core.R#L1182

I'm trying to align some of the parameters a bit.

pydeseq2/dds.py Outdated Show resolved Hide resolved
@BorisMuzellec
Copy link
Collaborator

BorisMuzellec commented Mar 28, 2023

Hi @mikelove, nice catch, thanks a lot for checking the code!

Please don't hesitate to open PRs or issues if you find other mistakes, or if you have suggestions to make :).

I'm merging this PR.

@BorisMuzellec BorisMuzellec changed the title dispersion prior variance BUG dispersion prior variance Mar 28, 2023
@BorisMuzellec BorisMuzellec merged commit 8cda857 into owkin:main Mar 28, 2023
@mikelove
Copy link
Contributor Author

Great.

I have a python beginner question: how can I do local development? That is, I've installed with pip install, but how can I now replace that installed version with a local copy of the code that I've cloned from GitHub?

@ghost
Copy link

ghost commented Mar 28, 2023

Hi @mikelove

how can I do local development?

Instead of pip install, just do pip install -e . in repository you cloned, this puts the package in editable mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants