Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack 5 🚢 #1438

Merged
merged 9 commits into from
May 18, 2022
Merged

Webpack 5 🚢 #1438

merged 9 commits into from
May 18, 2022

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented May 16, 2022 •
edited
Loading

Live on tufte.
Let's try this again again.

Last attempt was: #1060

@marcelgerber
Copy link
Member Author

The plan is to merge & deploy this tomorrow morning, if there are no objections.

danielgavrilov
danielgavrilov approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@danielgavrilov danielgavrilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it locally & deployed to playfair, all seems to work well!

Only skimmed the config changes without looking up webpack5 docs, but if there's anything there I should review, let me know.

@ikesau
Copy link
Member

ikesau commented May 17, 2022

Same as Gavrilov - ptolemy.owid.cloud is looking good. 🚀

@marcelgerber
Copy link
Member Author

Thank you! Deploying this now 🤞

@marcelgerber marcelgerber merged commit ea9b838 into master May 18, 2022
@marcelgerber marcelgerber deleted the webpack5 branch May 18, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgavrilov danielgavrilov danielgavrilov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelgerber @ikesau @danielgavrilov