New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use `fetch` instead of `fetchWithRetries` in SiteHeaderMenus #1102

Merged

marcelgerber merged 1 commit into master from fetch-menu-without-retries

Jan 25, 2022

Contributor

danielgavrilov commented Jan 25, 2022 •

edited

Loading

There is some Safari bug on both macOS and iOS that leads to a (0,m.fetchWithRetries) is not a function. error, since introducing #1066.

We could potentially see if #1060 fixes it, but until then we can just fetch the header menu without retries.

Slack discussion: https://owid.slack.com/archives/CQQUA2C2U/p1643017308010200

Error on Bugsnag: https://app.bugsnag.com/our-world-in-data/our-world-in-data-website/errors/61e8217018e327000758b9e3


          fix: use fetch instead of fetchWithRetries in SiteHeaderMenus

80cc435

There is some Safari bug on both macOS and iOS that leads to a `(0,m.fetchWithRetries) is not a function.` error.

Slack discussion: https://owid.slack.com/archives/CQQUA2C2U/p1643017308010200

Error on Bugsnag: https://app.bugsnag.com/our-world-in-data/our-world-in-data-website/errors/61e8217018e327000758b9e3

danielgavrilov requested a review from marcelgerber

January 25, 2022 17:56

Member

marcelgerber commented Jan 25, 2022

Yeah let's do this, and hope that it actually fixes things 🙌

marcelgerber merged commit 845ab2f into master

marcelgerber deleted the fetch-menu-without-retries branch

January 25, 2022 23:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet