Database integration #471
Merged
Database integration #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added visual for dark mode setting
Added listener for dark mode
|
|
|
Anybody looking at this? |
|
I am. |
|
|
Max1Truc
approved these changes
Mar 23, 2017
|
|
|
👍 Thanks everybody! Merging! |
|
cool ! |
|
@huytd You really need to learn to use the squash and merge button. |
|
Yes master 🙇 LOL, just kidding, I don't think Github has that button (at least, at the time I hit the merge), but yes, I should do it on the command line for big pull requests like this. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me like 5-6 hours of experimenting and bug fixes but I FINALLY got it working so a breakdown
I added sql settings into config.json so that people can modify to their needs easily
Added code to server to connect to database based on settings in config.json
Added code to log incorrect password input for admin (it was on the todo list)
This could really be useful for the future as well with a level/xp system I would start working on it but....I just spent like 5 hours on all this.....coffee and code || sleep
It's OKAY !