Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rudimentary border and increase squares' size for better performance #126

Merged
merged 1 commit into from
Jun 3, 2015

Conversation

neslinesli93
Copy link
Contributor

Add the logic for a very rudimentary (ugly) border.
Hoping for help from a design guy :P

@igorantun
Copy link
Collaborator

What would be the advantage of this compared to #123 ?

@neslinesli93
Copy link
Contributor Author

My implementation draws a rectangle around the playground.
#123's implementation draws infinite lines on the border, which forms a rectangle but do not stop when they form a corner of such rectangle: they continue indefinitely.
So if you could zoom out, in my implementation you would see a black rectangle, in #123 's implementation you would see a '#' (a grid)

@keithagroves
Copy link
Contributor

Also my implementation has collision detection but we can have both right? neslinesli93#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants