Mitigate arbitrary path traversal in download_private_file (GHSL-2024-183) #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen2345
approved these changes
Aug 12, 2024
texpert
force-pushed
the
fix-path-traversal-in-download-private-file
branch
from
795043d
to
f635218
Compare
…ause Rails 7.2 changed the behavior to only report errors that are not considered "handled" based on the `ActionDispatch::ExceptionWrapper.rescue_responses` list (see - rails/rails@a8d1d92) Also, for the `config.action_dispatch.show_exceptions` behaviour has changed - see rails/rails#50339
…ch corresponds to the new :none setting - see rails/rails#50339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks GHSL team member @p- for disovering and reporting this!
Arbitrary path traversal in
download_private_file(GHSL-2024-183) vulnerability reported:A path traversal vulnerability accessible via MediaController's download_private_file method allows authenticated users to download any file on the web server Camaleon CMS is running on (depending on the file permissions).
This PR fixes the vulnerability by introducing a check in the
CamaleonCmsLocalUploader'sfetch_filemethod for the filename to not include...Also, changed the exception-based control flow of the
fetch_fileto just returning errors, because:ActionDispatch::ExceptionWrapper.rescue_responseslist (see - rails/rails@a8d1d92)config.action_dispatch.show_exceptionshas changed - see Document developer-facing change toconfig.action_dispatch.show_exceptionsdefault rails/rails#50339