Skip to content

Commit

Permalink
northd: Reorder join_logical_ports.
Browse files Browse the repository at this point in the history
this makes the later active_active patches clearer as they need this new
order.
For now this has no real effect as these two parts are completely
independent.

Acked-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Felix Huettner <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
  • Loading branch information
felixhuettner authored and ovsrobot committed Dec 10, 2024
1 parent 5898449 commit d38544f
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions northd/northd.c
Original file line number Diff line number Diff line change
Expand Up @@ -2368,17 +2368,6 @@ join_logical_ports(const struct sbrec_port_binding_table *sbrec_pb_table,
}

struct ovn_datapath *od;
HMAP_FOR_EACH (od, key_node, ls_datapaths) {
ovs_assert(od->nbs);
for (size_t i = 0; i < od->nbs->n_ports; i++) {
const struct nbrec_logical_switch_port *nbsp
= od->nbs->ports[i];
join_logical_ports_lsp(ports, nb_only, both, od, nbsp,
nbsp->name, queue_id_bitmap,
tag_alloc_table);
}
}

struct hmapx dgps = HMAPX_INITIALIZER(&dgps);
HMAP_FOR_EACH (od, key_node, lr_datapaths) {
ovs_assert(od->nbr);
Expand All @@ -2399,6 +2388,17 @@ join_logical_ports(const struct sbrec_port_binding_table *sbrec_pb_table,
}
}

HMAP_FOR_EACH (od, key_node, ls_datapaths) {
ovs_assert(od->nbs);
for (size_t i = 0; i < od->nbs->n_ports; i++) {
const struct nbrec_logical_switch_port *nbsp
= od->nbs->ports[i];
join_logical_ports_lsp(ports, nb_only, both, od, nbsp,
nbsp->name, queue_id_bitmap,
tag_alloc_table);
}
}

/* Connect logical router ports, and logical switch ports of type "router",
* to their peers. */
struct ovn_port *op;
Expand Down

0 comments on commit d38544f

Please sign in to comment.