Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetSubjectVersion to schema registry api #74

Closed
tzachshabtay opened this issue Apr 2, 2021 · 3 comments · Fixed by #75
Closed

Add GetSubjectVersion to schema registry api #74

tzachshabtay opened this issue Apr 2, 2021 · 3 comments · Fixed by #75

Comments

@tzachshabtay
Copy link

Hi, in your current api you have getSubjectVersionSchema which maps to GET /subjects/:subject/versions/:version/schema but I'm missing a getSubjectVersion which maps to GET /subjects/:subject/versions/:version, this gets back the schema id (in addition to the schema string) which will be very helpful to me. Thanks.
@tzachshabtay tzachshabtay mentioned this issue Apr 2, 2021
Closed
ivank added a commit to ovotech/bit-node-tools that referenced this issue Apr 5, 2021
@ivank
Add an additonal schema registry endpoint
f26fac8 
Its not really used in castle / avro-kafkajs, but we better add it for
the spirit of completness. Also it was requested by some folk.

ovotech/castle#74
@ivank ivank mentioned this issue Apr 5, 2021
Merged
ivank added a commit to ovotech/bit-node-tools that referenced this issue Apr 6, 2021
@ivank
Add an additonal schema registry endpoint (#72)
1ca6f77 
Its not really used in castle / avro-kafkajs, but we better add it for
the spirit of completness. Also it was requested by some folk.

ovotech/castle#74
ivank added a commit that referenced this issue Apr 6, 2021
@ivank
Update Schema registry
536892c 
Should fix #74
@ivank ivank mentioned this issue Apr 6, 2021
Merged
@ivank ivank closed this as completed in #75 Apr 6, 2021
ivank added a commit that referenced this issue Apr 6, 2021
@ivank
Update Schema registry (#75)
0b33118 
Should fix #74
@tzachshabtay
Copy link
Author

@ivank thanks for the quick turnaround.
However, there's an issue here, the new endpoint returns schema as a string, and not as a Schema like getSubjectVersionSchema, can you please fix this (I don't want to call 2 endpoints)?
Thanks.

@ivank
Copy link
Contributor

ivank commented Apr 7, 2021

Well that's what the endpoint returns, You should be able to call JSON.parse does that work for you?

@tzachshabtay
Copy link
Author

That works, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Schema registry ovotech/castle
2 participants
@ivank @tzachshabtay