Fix a deadlock when leader change if enable leader-only option. #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ovsdbClient.connect
andovsdbClient.update3
share the same monitorsMutex mutex.When
client.WithLeaderOnly(true)
is enabled, the client will monitor an extra_Server
db and amonitor_cond
rpc call will be sent to the server. If another db sends anupdate3
notification to the client, the client will hold the lock, and reconnect will be trapped.Example
connect:
libovsdb/client/client.go
Lines 283 to 306 in ce19516
update3:
libovsdb/client/client.go
Lines 735 to 739 in ce19516
Edit: it's not easy to reproduce. We found this issue in a large cluster and sb has a lot of pressure.