Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache: Fix Delete Handling #243

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

dave-tucker
Copy link
Collaborator

We can't rely on the Delete field of RowUpdate2 being non-nil as
ovsdb-server sends a {"delete": null} which the Go JSON parser makes
equivalent to nil.

Signed-off-by: Dave Tucker [email protected]

We can't rely on the Delete field of RowUpdate2 being non-nil as
ovsdb-server sends a {"delete": null} which the Go JSON parser makes
equivalent to nil.

Signed-off-by: Dave Tucker <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1334518988

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 25 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 73.004%

Files with Coverage Reduction New Missed Lines %
cache/cache.go 3 71.76%
server/monitor.go 3 45.86%
client/client.go 19 68.39%
Totals Coverage Status
Change from base Build 1333653363: -0.3%
Covered Lines: 4005
Relevant Lines: 5486

💛 - Coveralls

Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dave-tucker dave-tucker merged commit c6d93b9 into ovn-org:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants