Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more logging to make debugging easier #242

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Add more logging to make debugging easier #242

merged 1 commit into from
Oct 14, 2021

Conversation

dave-tucker
Copy link
Collaborator

Signed-off-by: Dave Tucker [email protected]

@coveralls
Copy link

coveralls commented Oct 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1343290573

  • 40 of 45 (88.89%) changed or added relevant lines in 8 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 72.669%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/server.go 0 1 0.0%
client/client.go 4 6 66.67%
server/monitor.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
client/client.go 8 66.47%
Totals Coverage Status
Change from base Build 1343268103: -0.001%
Covered Lines: 4052
Relevant Lines: 5576
💛 - Coveralls

trozet
trozet approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dave-tucker dave-tucker merged commit 8f9d582 into ovn-org:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dave-tucker @coveralls @trozet