types declaration file for typescript user

[cdelhomme]

Here is the typescript declaration file for this plugin.

[ovidiuch]

@cdelhomme Wouldn't DragdealerOptions (plural) be a better name?

[ovidiuch]

And it should be Dragdealer instead of DragDealer.

[cdelhomme]

you can call the options interface DragdealerOptions if you want. no matter , the only thing is that you do not change the Dragdealer syntaxe for understanding purpose . it should be writen like you call your javascript plugin Dragdealer. .
in fact the use wil be like this :

class sample {
 slider: Dragdealer;

 init(){
   var options:DragdealerOptions = {
   x: 1,
   steps: 2,
   loose: true,
   callback: (x, y) => {
     // Only 0 and 1 are the possible values because of "steps: 2"
     if (!x) {
       this.slider.disable();
       $('#slide-to-unlock-new').fadeOut();
     }
   }
  }
 this.slide = new Dragdealer('slide-to-unlock-new', options);
 }
}

where in typescript the line
slider :Dragdelaer , is to declare a property of the class that will be of Dragdealer type representing by the interface Dragdelaer

its the same for the line
var options:DragdealerOptions = { .....}
we declare and set a variable of type DragdealerOptions .

and when we do the
this.slide = new Dragdealer(...) the new is declare in the interface DragdealerConstructor that return an object symbolize by the interface Dragdealer.

[ovidiuch]

@cdelhomme Why did you close the PR? I wanted to merge after that small change.

[cdelhomme]

Sorry i've click on the wrong button

[ovidiuch]

No worries! 😄

So are you OK with changing DragDealearOption to DragdealearOptions?

[cdelhomme]

Yes no problem Envoyé depuis Yahoo Mail pour Android Le mer., oct. 31, 2018 à 11:13, Ovidiu Cherecheș<[email protected]> a écrit : No worries! 😄 So are you OK with changing DragDealearOption to DragdealearOptions? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[cdelhomme]

no problem