Clean test and example on cloud_project_kube resource with private network #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…twork : * remove `ovh_vrack_cloudproject` resource since from Q2 2024 all public cloud projects (existing or new) have a vrach attached to them. * remove unnecessary `depends_on` that terraform / opentofu engine can manage. * add `node_subnet_id` to avoid race condition in terraform execution plan if the subnet & the kube cluster are created in // resulting in error like `Private network xxx does not have any subnet` * add a managed gateway * in the test, add a random vlanId for a smoother run.
nicolaslacroux
approved these changes
Nov 21, 2024
yomovh
requested review from
rbeuque74,
deathiop,
amstuta,
mxpetit and
marie-j
as code owners
Lucasgranet
suggested changes
Nov 21, 2024
| @@ -974,7 +969,7 @@ func TestAccCloudProjectKubeVRack(t *testing.T) { | |||
| } | |||
| configData2 := configData{ | |||
| ServiceName: serviceName, | |||
| VrackID: vrackID, | |||
| VlanID: vlanID, | |||
| Name: name, | |||
| Region: region, | |||
| DefaultVrackGateway: "10.4.0.1", | |||
There was a problem hiding this comment.
Suggested change
| DefaultVrackGateway: "10.4.0.1", | |
| DefaultVrackGateway: "", |
Let's the DHCP server gives the GatewayIP.
(ATM, the KubeVRack with a gateway is not working, the provided DefaultVrackGateway is not matching the deployed one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ovh_vrack_cloudprojectresource since from Q2 2024 all public cloud projects (existing or new) have a vrach attached to them.depends_onthat terraform / opentofu engine can manage.node_subnet_idto avoid race condition in terraform execution plan if the subnet & the kube cluster are created in // resulting in error likePrivate network xxx does not have any subnetType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make testacc TESTARGS="-run TestAccCloudProjectKubeVRack"Test Configuration:
>tofu -version OpenTofu v1.8.4 on darwin_arm64