-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ovh_iploadbalancing_http_route resource #35
Conversation
hi @eliecharra thanks a lot for this job i have a few questions:
thanks again |
Doc written in french, docs should be redacted "english first" in mind as french is not so open source compliant imho ... but this is a detail ;-)
I havent finished writing tests cases yet, maybe I'll need some help afterwards.
Sure ! |
@yanndegat Actually acc test are not launched by Travis, did you plan to configure them ? I'd like to cover this resources with acc test if possible |
hi @eliecharra i have to sync with @tombuildsstuff |
Ok, let me know when evrything is ready, I'll try to run my tests on it. |
hi @eliecharra |
acc test should be setup to run on every PR imho. The openstack provider, for example, is running openlab CI on every pull request https://github.com/terraform-providers/terraform-provider-openstack/pull/261 By running my test on it, I mean on this pull request through a continous integration process. |
well the openstack provider is different from other cloud providers in a sense that there's no real cloud provider thus billed infrastructure behind. imagine you'd made a PR on a compute resource that mines bitcoins... |
- read resource after create/update - resource schema as first go definition
Ec http pr review
Sorry OVH related doc is only in french ... https://docs.ovh.com/fr/load-balancer/routes/