Add S3 Credential datasource and resource

[yvigara]

Add the datasources and resource to create and retrieve S3 Credentials (AccessKeyId and SecretAccessKey) required to access S3 buckets. Fixes #285

[scraly]

Hi,
thanks for the PR, it's a good addition :)

I have an issue with the first acceptance test:

[scraly]

About acceptance test, is it possible them like this example?
https://github.com/ovh/terraform-provider-ovh/blob/master/ovh/data_cloud_project_database_ip_restrictions_test.go

Thanks

[yvigara]

@scraly thanks a lot for the feedback. All the requested changes should be resolved now.

[scraly]

Thanks for the modifications.

Also, regarding the acceptance tests, can you edit them to be consistent like this example please?
https://github.com/ovh/terraform-provider-ovh/blob/master/ovh/data_cloud_project_database_ip_restrictions_test.go

Thanks

[yvigara]

Just to be sure, do you mean renaming the config variable to match the test function, keeping it as a simple string and moving the string formatting in the test function?

[scraly]

I mean moving the hash function to another file, next to the resource file.
Thanks to that in this new helpers file, in the future we can add another helper functions to that resource.

[yvigara]

I'm really sorry I don't see which hash function you are referring to. Apart the naming convention on the config variable and how it's formatted I don't see much difference between these acceptance test functions and the data_cloud_project_database_ip_restrictions_test.go one.
What am I missing?

[scraly]

Sorry, I reviewed two PRs at the same time so my brain have switched :-D.
About the acceptance test I mean, yes, the const as string and how to pass the config.
Even if a lot of different people contribute to the repo, the goal is to try to keep a coherence when it is possible :).

[yvigara]

Should be all fixed now

[scraly]

Perfect, thanks :-)
Acceptance tests are well written now and all the tests are in success.