Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch all IPs for dedicated servers #149

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

glorpen
Copy link
Contributor

@glorpen glorpen commented Jul 29, 2020

Adds ips property with all ip blocks assigned to dedicated server.

@ghost ghost added the size/XS label Jul 29, 2020
@yanndegat
Copy link
Collaborator

hi @glorpen

thanks a lot for this PR. LGTM

i'll run the acceptance tests againt it.

could you also update the datasource doc in the website/ dir accordingly ?

thanks

@glorpen
Copy link
Contributor Author

glorpen commented Jul 29, 2020

@yanndegat done :)

@yanndegat
Copy link
Collaborator

thanks a lot once again.

tests are green.

@yanndegat yanndegat merged commit c16da1e into ovh:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants