Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cookie-policy): use sources instead of build #7634

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix(cookie-policy): use sources instead of build #7634

merged 1 commit into from
Jul 21, 2022

Conversation

cbourgois
Copy link
Contributor

Question Answer
Branch? release/stack-clean-apps
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix MANAGER-9745,
License BSD 3-Clause

Description

Stop building @ovh-ux/manager-cookie-policy as this feature is now built-in in container and this package is only used in @ovh-ux/sign-up-app.

@cbourgois cbourgois requested a review from a team as a code owner July 21, 2022 08:33
@github-actions github-actions bot added the refactor A code change that neither fixes a bug nor adds a feature label Jul 21, 2022
fix(cookie-policy): use sources instead of build
bf9d49c 
ref: MANAGER-9745

Signed-off-by: Cyrille Bourgois <[email protected]>
@cbourgois cbourgois force-pushed the refactor/cookie-policy branch from aadf84a to bf9d49c Compare July 21, 2022 09:52
frenautvh
frenautvh approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@frenautvh frenautvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading the package.json i'm wondering why we are using keywords since the package is private anyway, not really the scope of this PR but it should be removed as it's useless

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cbourgois cbourgois merged commit 35bb093 into release/stack-clean-apps Jul 21, 2022
@cbourgois cbourgois deleted the refactor/cookie-policy branch July 21, 2022 12:11
@cbourgois cbourgois mentioned this pull request Jul 21, 2022
Merged
cbourgois pushed a commit that referenced this pull request Jul 27, 2022
@cbourgois
fix(cookie-policy): use sources instead of build (#7634)
2af44da 
ref: MANAGER-9745

Signed-off-by: Cyrille Bourgois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakariasahmane zakariasahmane zakariasahmane approved these changes

@frenautvh frenautvh frenautvh approved these changes

@mohammed-zahaf mohammed-zahaf Awaiting requested review from mohammed-zahaf mohammed-zahaf was automatically assigned from ovh/team-manager-dev-angularjs

@vks-ovh vks-ovh Awaiting requested review from vks-ovh vks-ovh was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbourgois @frenautvh @zakariasahmane