Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hub): remove common manager's features #7582

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

cbourgois
Copy link
Contributor

Question Answer
Branch? release/stack-clean-apps
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix MANAGER-9201
License BSD 3-Clause

Description

Remove following packages usage in @ovh-ux/manager-hub-app since theses functionalities are now supported by the container :

  • @ovh-ux/manager-account-sidebar,
  • @ovh-ux/manager-cookie-policy
  • @ovh-ux/manager-navbar
  • @ovh-ux/manager-notifications-sidebar
  • @ovh-ux/manager-preloader
  • @ovh-ux/ng-ovh-sso-auth-modal-plugin
  • @ovh-ux/ng-ui-router-line-progress

@cbourgois cbourgois requested a review from a team as a code owner July 18, 2022 08:12
@cbourgois cbourgois requested review from y4nnL, marie-j and sachinrameshn and removed request for a team July 18, 2022 08:12
@github-actions github-actions bot added universe-hub refactor A code change that neither fixes a bug nor adds a feature labels Jul 18, 2022
ref: MANAGER-9201

Signed-off-by: Cyrille Bourgois <[email protected]>
@cbourgois cbourgois force-pushed the refactor/clean-hub branch from 80b6566 to c6850e4 Compare July 18, 2022 09:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cbourgois cbourgois merged commit 81e5d2e into release/stack-clean-apps Jul 18, 2022
@cbourgois cbourgois deleted the refactor/clean-hub branch July 18, 2022 15:24
cbourgois pushed a commit that referenced this pull request Jul 27, 2022
ref: MANAGER-9201

Signed-off-by: Cyrille Bourgois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature universe-hub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants