Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/remove apiv7 usage #7504

Closed
wants to merge 0 commits into from
Closed

Feat/remove apiv7 usage #7504

wants to merge 0 commits into from

Conversation

cbourgois
Copy link
Contributor

@cbourgois cbourgois commented Jul 6, 2022 •
edited
Loading

Question Answer
Branch? develop
Bug fix? yes
New feature? yes
Breaking change? yes
Tickets Fix MANAGER-9646
License BSD 3-Clause

Description

Remove APIv7 usages and references in @ovh-ux/ovh-reket, @ovh-ux/manager-telecom, @ovh-ux/manager-web, @ovh-ux/manager-core, @ovh-ux/ng-ovh-request-taggerpackages.

Related PR :

Todo

@cbourgois cbourgois marked this pull request as ready for review July 7, 2022 08:58
@cbourgois cbourgois requested a review from a team as a code owner July 7, 2022 08:58
anooparveti
anooparveti previously approved these changes Jul 7, 2022
View reviewed changes
Jisay
Jisay previously approved these changes Jul 8, 2022
View reviewed changes
@cbourgois cbourgois dismissed stale reviews from Jisay and anooparveti via 3e129ec July 8, 2022 16:16
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@ovh-ux/ng-ovh-api-wrappers UPDATED 4.0.11 5.0.0
ovh-api-services UPDATED 14.0.6 15.0.0

@antleblanc antleblanc mentioned this pull request Jul 11, 2022
Closed
8 tasks
frenautvh
frenautvh previously approved these changes Jul 11, 2022
View reviewed changes
zakariasahmane
zakariasahmane previously approved these changes Jul 12, 2022
View reviewed changes
@antleblanc
Copy link
Member

question:

39cdb34 > Won't provide a new version. Expected bahavior?
ae5bbf1 > Commit is signed twice.
4eb9495 > Won't provide a new version. Expected bahavior?
3e129ec > Won't provide a new version. Expected bahavior?

@antleblanc antleblanc added the question Further information is requested label Jul 15, 2022
@cbourgois cbourgois dismissed stale reviews from zakariasahmane and frenautvh via 0ed2c46 July 20, 2022 07:34
@cbourgois cbourgois force-pushed the feat/remove-apiv7-usage branch from 3e129ec to 0ed2c46 Compare July 20, 2022 07:34
@cbourgois
Copy link
Contributor Author

question:

39cdb34 > Won't provide a new version. Expected bahavior? ae5bbf1 > Commit is signed twice. 4eb9495 > Won't provide a new version. Expected bahavior? 3e129ec > Won't provide a new version. Expected bahavior?

Rebased on develop + reworded commits.

@cbourgois cbourgois requested a review from anooparveti July 20, 2022 08:49
antleblanc
antleblanc previously approved these changes Jul 21, 2022
View reviewed changes
@antleblanc antleblanc removed the question Further information is requested label Jul 21, 2022
anooparveti
anooparveti previously approved these changes Jul 25, 2022
View reviewed changes
@cbourgois cbourgois changed the base branch from develop to release/stack-clean-apps July 26, 2022 07:29
@cbourgois cbourgois dismissed stale reviews from anooparveti and antleblanc July 26, 2022 07:29

The base branch was changed.

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jul 26, 2022
@cbourgois
Copy link
Contributor Author

Update target branch to release/stack-clean-apps

@cbourgois cbourgois closed this Jul 26, 2022
@cbourgois cbourgois force-pushed the feat/remove-apiv7-usage branch from 0ed2c46 to 9284dbf Compare July 26, 2022 08:47
@cbourgois cbourgois deleted the feat/remove-apiv7-usage branch July 26, 2022 08:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cbourgois cbourgois mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti left review comments

@Jisay Jisay Jisay left review comments

@antleblanc antleblanc antleblanc left review comments

@zakariasahmane zakariasahmane Awaiting requested review from zakariasahmane

@frenautvh frenautvh Awaiting requested review from frenautvh

Assignees
No one assigned
Labels
feature New feature has conflicts Has conflicts to resolve before merging quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cbourgois @antleblanc @Jisay @anooparveti @frenautvh @zakariasahmane