Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overthebox.remote): update poller when tab switching before result #4383

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

Steffy29
Copy link
Contributor

@Steffy29 Steffy29 commented Feb 3, 2021

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #UXCT-369
License BSD 3-Clause

Description

When tab switching before result for the poller call, not display error message which is not necessary here.

@Steffy29 Steffy29 self-assigned this Feb 3, 2021
@Steffy29 Steffy29 requested a review from a team as a code owner February 3, 2021 17:17
antleblanc
antleblanc previously approved these changes Feb 3, 2021
@antleblanc
Copy link
Member

Rewriting history.

antleblanc and others added 2 commits February 8, 2021 17:34
ref: UXCT-369

Co-authored-by: Stephanie Moallic <[email protected]>
Signed-off-by: Antoine Leblanc <[email protected]>
Co-authored-by: Stephanie Moallic <[email protected]>
Signed-off-by: Antoine Leblanc <[email protected]>
@antleblanc antleblanc force-pushed the feat/overthebox-error-message-misdisplayed branch from 9a7fe6b to 95f16b0 Compare February 8, 2021 16:38
@antleblanc antleblanc changed the title feat(otb.remote): update poller when tab switching before result fix(overthebox.remote): update poller when tab switching before result Feb 8, 2021
@antleblanc antleblanc added bug Something isn't working refactor A code change that neither fixes a bug nor adds a feature and removed feature New feature labels Feb 8, 2021
@antleblanc
Copy link
Member

History has been updated.

@antleblanc antleblanc merged commit e9efadc into develop Feb 9, 2021
@antleblanc antleblanc deleted the feat/overthebox-error-message-misdisplayed branch February 9, 2021 08:04
@antleblanc antleblanc mentioned this pull request Feb 9, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quality check: ok refactor A code change that neither fixes a bug nor adds a feature universe-telecom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants