Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated): account contacts lazy loading #4342

Merged
merged 2 commits into from
Feb 9, 2021
Merged

feat(dedicated): account contacts lazy loading #4342

merged 2 commits into from
Feb 9, 2021

Conversation

frenautvh
Copy link
Contributor

@frenautvh frenautvh commented Jan 26, 2021 •
edited by antleblanc
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no
Tickets MANAGER-6352, DTRSD-28678
License BSD 3-Clause

Description

Lazy load account/contacts section

@frenautvh frenautvh requested a review from a team as a code owner January 26, 2021 14:05
@frenautvh frenautvh requested review from ganeshkumar1989, Jisay and JeremyDec and removed request for a team January 26, 2021 14:05
JeremyDec
JeremyDec previously approved these changes Jan 27, 2021
View reviewed changes
marie-j
marie-j previously approved these changes Jan 28, 2021
View reviewed changes
packages/manager/apps/dedicated/client/app/account/account.bundle.js
@@ -1,23 +1,4 @@
import './account.routing';
import './contacts/request/change/user-contacts-request-change.controller';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧹

@frenautvh frenautvh force-pushed the feat/dedicated-account-contacts-lazy-load branch from c0bce9f to 8a37c48 Compare January 28, 2021 10:24
@frenautvh
Copy link
Contributor Author

i just force pushed a commit to add missing imports :
'./contacts/request/change/user-contacts-request-change.controller' looks like it's not used because the corresponding template is never imported BUT in fact the template is included with a dynamic ng-include ...
a grep is not helpfull in that case to detect unused files so we have to be careful :/

@frenautvh frenautvh force-pushed the feat/dedicated-account-contacts-lazy-load branch from 8a37c48 to 63d991f Compare January 28, 2021 12:44
Base automatically changed from feat/breadcrumb-billing-useraccount to develop January 29, 2021 13:18
@antleblanc antleblanc dismissed stale reviews from ganeshkumar1989, marie-j, and JeremyDec January 29, 2021 13:18

The base branch was changed.

@frenautvh frenautvh force-pushed the feat/dedicated-account-contacts-lazy-load branch from 63d991f to d6a3467 Compare January 29, 2021 13:40
@frenautvh frenautvh removed the blocked Don't merge yet label Jan 29, 2021
marie-j
marie-j previously approved these changes Feb 1, 2021
View reviewed changes
@frenautvh frenautvh force-pushed the feat/dedicated-account-contacts-lazy-load branch from d6a3467 to e0bd98a Compare February 5, 2021 12:48
@frenautvh frenautvh force-pushed the feat/dedicated-account-contacts-lazy-load branch from cf9ac55 to 3f7ef92 Compare February 8, 2021 15:30
marie-j
marie-j previously approved these changes Feb 9, 2021
View reviewed changes
antleblanc
antleblanc previously approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@antleblanc antleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Changes looks good to me.

Could you please update body commit in order to provide ticket reference in it?

Thank you!

@antleblanc antleblanc added the bug Something isn't working label Feb 9, 2021
@antleblanc
Copy link
Member

Rewriting history.

@antleblanc antleblanc dismissed stale reviews from marie-j and themself via 8fad7d9 February 9, 2021 08:54
@antleblanc antleblanc force-pushed the feat/dedicated-account-contacts-lazy-load branch from 3f7ef92 to 8fad7d9 Compare February 9, 2021 08:54
@antleblanc
Copy link
Member

History has been rewrite successfully.

@antleblanc antleblanc merged commit 1256306 into develop Feb 9, 2021
@antleblanc antleblanc deleted the feat/dedicated-account-contacts-lazy-load branch February 9, 2021 09:21
@antleblanc antleblanc mentioned this pull request Feb 9, 2021
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antleblanc antleblanc antleblanc approved these changes

@Jisay Jisay Awaiting requested review from Jisay

@ganeshkumar1989 ganeshkumar1989 Awaiting requested review from ganeshkumar1989

@JeremyDec JeremyDec Awaiting requested review from JeremyDec

@marie-j marie-j Awaiting requested review from marie-j

Assignees
No one assigned
Labels
bug Something isn't working feature New feature quality check: ok universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frenautvh @antleblanc @ganeshkumar1989 @marie-j @JeremyDec