Feat/kube restrictions #4316
Merged
Feat/kube restrictions #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marie JONES <[email protected]>
marie-j
force-pushed
the
feat/kube-restrictions
branch
from
8e0ef60 to
a0bf50b
Compare
mohammed-zahaf
previously approved these changes
Jan 21, 2021
antleblanc
previously approved these changes
Jan 21, 2021
JeremyDec
reviewed
Jan 21, 2021
packages/manager/modules/pci/src/projects/project/kubernetes/details/restrictions/IP.class.js
Outdated
Show resolved
Hide resolved
packages/manager/modules/pci/src/projects/project/kubernetes/details/restrictions/controller.js
Show resolved
Hide resolved
marie-j
dismissed stale reviews from antleblanc and mohammed-zahaf
via
ae8ba82
marie-j
force-pushed
the
feat/kube-restrictions
branch
from
a0bf50b to
ae8ba82
Compare
|
Only change made since review was to rename IP class to IPv4 |
JeremyDec
previously approved these changes
Jan 22, 2021
antleblanc
previously approved these changes
Jan 22, 2021
marie-j
force-pushed
the
feat/kube-restrictions
branch
from
ae8ba82 to
daec259
Compare
ref: MANAGER-5296 Signed-off-by: Marie JONES <[email protected]>
marie-j
force-pushed
the
feat/kube-restrictions
branch
from
daec259 to
1d69b83
Compare
Signed-off-by: CDS Translator Agent <[email protected]>
antleblanc
approved these changes
Feb 8, 2021
JeremyDec
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developDescription
Related