feat: add object & cloud-archives storages #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: MANAGER-2290, MANAGER-2289, MANAGER-2361, MANAGER-2362, MANAGER-2359, MANAGER-2360
cbourgois
requested review from
antleblanc,
frenautvh,
jleveugle and
marie-j
as code owners
antleblanc
reviewed
Apr 12, 2019
packages/manager/modules/pci/src/projects/project/storages/cloud-archives/add/index.js
Outdated
Show resolved
Hide resolved
...nager/modules/pci/src/projects/project/storages/cloud-archives/cloud-archive/delete/index.js
Outdated
Show resolved
Hide resolved
...nager/modules/pci/src/projects/project/storages/cloud-archives/cloud-archive/delete/index.js
Outdated
Show resolved
Hide resolved
...ages/manager/modules/pci/src/projects/project/storages/cloud-archives/cloud-archive/index.js
Outdated
Show resolved
Hide resolved
...ages/manager/modules/pci/src/projects/project/storages/cloud-archives/cloud-archive/index.js
Outdated
Show resolved
Hide resolved
packages/manager/modules/pci/src/projects/project/storages/objects/object/index.js
Outdated
Show resolved
Hide resolved
packages/manager/modules/pci/src/projects/project/storages/objects/object/object/add/index.js
Outdated
Show resolved
Hide resolved
packages/manager/modules/pci/src/projects/project/storages/objects/object/object/add/index.js
Outdated
Show resolved
Hide resolved
...ages/manager/modules/pci/src/projects/project/storages/objects/object/object/delete/index.js
Outdated
Show resolved
Hide resolved
...ages/manager/modules/pci/src/projects/project/storages/objects/object/object/delete/index.js
Outdated
Show resolved
Hide resolved
marie-j
reviewed
Apr 12, 2019
packages/manager/modules/pci/src/projects/project/storages/containers/add/add.controller.js
Outdated
Show resolved
Hide resolved
packages/manager/modules/pci/src/projects/project/storages/containers/add/add.controller.js
Outdated
Show resolved
Hide resolved
...anager/modules/pci/src/projects/project/storages/containers/container/container.component.js
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| initLoaders() { | ||
| this.prefix = '/'; |
packages/manager/modules/pci/src/projects/project/storages/containers/containers.service.js
Outdated
Show resolved
Hide resolved
|
65 files and only one commit ? :( |
FredericEspiau
suggested changes
Apr 12, 2019
| component: 'pciProjectStorageContainersContainer', | ||
| resolve: { | ||
| containerId: /* @ngInject */ $transition$ => $transition$.params().containerId, | ||
| addObject: /* @ngInject */ ($state, projectId, containerId) => () => $state.go('pci.projects.project.storages.objects.object.add', { |
There was a problem hiding this comment.
Looks like this won't add an object but this will change state to be able to add an object, this is confusing
| containerId, | ||
| objectId: object.name, | ||
| }), | ||
| goBack: /* @ngInject */ ($state, projectId) => () => $state.go('pci.projects.project.storages.objects', { |
There was a problem hiding this comment.
goBack is also confusing, what if was nothing before ? exit looks more generic to me
| import get from 'lodash/get'; | ||
| import map from 'lodash/map'; | ||
|
|
||
| import Container from '../container.class'; |
There was a problem hiding this comment.
Suggested change
| import Container from '../container.class'; | |
| import Container from '../container'; |
would be enough imo :)
packages/manager/modules/pci/src/projects/project/storages/containers/add/add.controller.js
Outdated
Show resolved
Hide resolved
packages/manager/modules/pci/src/projects/project/storages/containers/add/add.controller.js
Outdated
Show resolved
Hide resolved
packages/manager/modules/pci/src/projects/project/storages/containers/container/container.html
Show resolved
Hide resolved
packages/manager/modules/pci/src/projects/project/storages/containers/container/container.html
Outdated
Show resolved
Hide resolved
...r/modules/pci/src/projects/project/storages/containers/container/delete/delete.controller.js
Show resolved
Hide resolved
...s/manager/modules/pci/src/projects/project/storages/containers/container/object/add/add.html
Outdated
Show resolved
Hide resolved
...s/manager/modules/pci/src/projects/project/storages/containers/container/object/add/add.html
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add object & cloud-archives storages
Description of the Change
Add 3 entries in
packages/manager/modules/pci/src/projects/project/storages:containers: containing componentsobjects: routing for Object Storage, usingcontainerscomponentscloud-archives: routing for Cloud Archive, usingcontainerscomponentsref: MANAGER-2290, MANAGER-2289, MANAGER-2361, MANAGER-2362, MANAGER-2359, MANAGER-2360
6a555ab — feat: add object & cloud-archives storages
Related PR :
/cc @jleveugle @marie-j @antleblanc