Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web.private-database): add Mysql 8.0 label #3456

Merged
merged 1 commit into from
Aug 17, 2020
Merged

feat(web.private-database): add Mysql 8.0 label #3456

merged 1 commit into from
Aug 17, 2020

Conversation

wiseflat
Copy link
Contributor

Signed-off-by: mathieu.garcia [email protected]

@wiseflat wiseflat requested a review from a team as a code owner August 17, 2020 14:13
@antleblanc antleblanc self-assigned this Aug 17, 2020
@antleblanc antleblanc added universe-web-cloud enhancement New feature or request labels Aug 17, 2020
@antleblanc antleblanc changed the base branch from master to develop August 17, 2020 14:51
antleblanc
antleblanc approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@antleblanc antleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wiseflat!

In order to improve the maintainability of this part, we planned to turn the version number as a dynamic slice of the translation in order to be able to rely on the following ENUM hosting.PrivateDatabase.AvailableVersionEnum.

Thanks for your contribution @wiseflat!

@antleblanc antleblanc merged commit fb70f22 into ovh:develop Aug 17, 2020
@antleblanc antleblanc mentioned this pull request Aug 17, 2020
Merged
10 tasks
radireddy pushed a commit that referenced this pull request Aug 19, 2020
@wiseflat
feat(private-database): add mysql 8.0 label (#3456)
aa25cd5 
Signed-off-by: Mathieu Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammed-zahaf mohammed-zahaf mohammed-zahaf approved these changes

@antleblanc antleblanc antleblanc approved these changes

@Jisay Jisay Awaiting requested review from Jisay

@radireddy radireddy Awaiting requested review from radireddy

@JeremyDec JeremyDec Awaiting requested review from JeremyDec

Assignees

@antleblanc antleblanc

Labels
enhancement New feature or request universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiseflat @antleblanc @mohammed-zahaf