Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: prevent error ENOTDIR when starting application #3441

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

antleblanc
Copy link
Member

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets no
License BSD 3-Clause

Description

👷 Build

build: prevent error ENOTDIR when starting application

Some OSes stores custom attribute in a specific files like .DS_Store.

(node:88679) UnhandledPromiseRejectionWarning: Error: ENOTDIR: not a directory, open 'packages/manager/apps/.DS_Store/package.json'

🏠 Internal

No quality check required.

Signed-off-by: Antoine Leblanc [email protected]

cc @marie-j

@antleblanc antleblanc added the build Changes that affect the build system or external dependencie label Aug 14, 2020
@antleblanc antleblanc requested a review from a team August 14, 2020 14:57
@antleblanc antleblanc self-assigned this Aug 14, 2020
Some OSes stores custom attribute in a specific files like `.DS_Store`.

```sh
(node:88679) UnhandledPromiseRejectionWarning: Error: ENOTDIR: not a directory, open 'packages/manager/apps/.DS_Store/package.json'
```

Signed-off-by: Antoine Leblanc <[email protected]>
@antleblanc antleblanc force-pushed the bugfix/start-application-script branch from 197a05f to ef28752 Compare August 14, 2020 15:50
@antleblanc antleblanc merged commit d277fdb into develop Aug 14, 2020
@antleblanc antleblanc deleted the bugfix/start-application-script branch August 14, 2020 15:52
@antleblanc antleblanc mentioned this pull request Aug 14, 2020
10 tasks
radireddy pushed a commit that referenced this pull request Aug 19, 2020
Some OSes stores custom attribute in a specific files like `.DS_Store`.

```sh
(node:88679) UnhandledPromiseRejectionWarning: Error: ENOTDIR: not a directory, open 'packages/manager/apps/.DS_Store/package.json'
```

Signed-off-by: Antoine Leblanc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencie
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants