Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: only provide esm target for private packages #3403

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

frenautvh
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no
Tickets
License BSD 3-Clause

Description

There is no need in providing multiple targets for private monorepo packages. It slows down the build time.

@frenautvh frenautvh added performance Improves performance build Changes that affect the build system or external dependencie labels Aug 7, 2020
@frenautvh frenautvh requested a review from a team as a code owner August 7, 2020 06:52
JeremyDec
JeremyDec previously approved these changes Aug 7, 2020
marie-j
marie-j previously approved these changes Aug 7, 2020
antleblanc
antleblanc previously approved these changes Aug 7, 2020
packages/manager/modules/account-sidebar/rollup.config.js Outdated Show resolved Hide resolved
@antleblanc antleblanc dismissed stale reviews from marie-j, JeremyDec, and themself via 9a79b47 August 7, 2020 07:42
@antleblanc antleblanc merged commit 334fbf4 into develop Aug 7, 2020
@antleblanc antleblanc deleted the build/private-es-module branch August 7, 2020 07:51
@antleblanc antleblanc mentioned this pull request Aug 7, 2020
10 tasks
radireddy pushed a commit that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencie performance Improves performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants