Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack.move): rework for pack move to add fiber offers #3125

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

Steffy29
Copy link
Contributor

@Steffy29 Steffy29 commented Jun 16, 2020

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #UXCT-193, #MANAGER-5273
License BSD 3-Clause

Description

  • rework for pack move to add copper and fiber offers choice for the customer
  • add the new eligibility search for copper and fiber offers
  • add the fiber offers into the result of offers available

🔗 Related

@Steffy29 Steffy29 requested a review from marie-j June 18, 2020 10:45
@Steffy29 Steffy29 force-pushed the feat/pack-xdsl-move-offers branch 2 times, most recently from 9a0e2b1 to 99de0b1 Compare June 30, 2020 12:48
@Steffy29 Steffy29 requested a review from frenautvh July 2, 2020 13:01
@Steffy29 Steffy29 force-pushed the feat/pack-xdsl-move-offers branch from 99de0b1 to dc3a571 Compare July 3, 2020 13:03
@Steffy29 Steffy29 requested a review from JeremyDec July 3, 2020 13:13
@ovh ovh deleted a comment from ovh-cds Jul 17, 2020
@ovh ovh deleted a comment from ovh-cds Jul 17, 2020
@ovh ovh deleted a comment from ovh-cds Jul 17, 2020
@Steffy29 Steffy29 requested a review from a team July 20, 2020 12:26
@Steffy29 Steffy29 force-pushed the feat/pack-xdsl-move-offers branch from 4284242 to 5b656c0 Compare July 22, 2020 15:33
@ovh ovh deleted a comment from ovh-cds Jul 23, 2020
@ovh ovh deleted a comment from ovh-cds Jul 23, 2020
@ovh ovh deleted a comment from ovh-cds Jul 27, 2020
Copy link
Contributor

@JeremyDec JeremyDec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review due to the size of the PR

@Steffy29 Steffy29 requested a review from JeremyDec July 31, 2020 14:28
@Steffy29 Steffy29 force-pushed the feat/pack-xdsl-move-offers branch from a50dfe5 to ef39f1b Compare August 5, 2020 12:02
@ovh ovh deleted a comment from ovh-cds Aug 7, 2020
- Add the new eligibility search for copper and fiber offers
- Add the fiber offers into the result of offers available

ref: UXCT-193

Signed-off-by: Stephanie Moallic <[email protected]>
@antleblanc
Copy link
Member

I'm rebasing this Pull Request on develop branch, in order to be able to merge it.

Thank you!

@antleblanc antleblanc force-pushed the feat/pack-xdsl-move-offers branch from b51fff0 to 340ecab Compare August 10, 2020 12:11
@antleblanc
Copy link
Member

Now rebased on develop. Waiting CI/CD reports.

@antleblanc antleblanc merged commit 1d4cced into develop Aug 10, 2020
@antleblanc antleblanc deleted the feat/pack-xdsl-move-offers branch August 10, 2020 12:51
@antleblanc antleblanc mentioned this pull request Aug 10, 2020
10 tasks
radireddy pushed a commit that referenced this pull request Aug 19, 2020
- Add the new eligibility search for copper and fiber offers
- Add the fiber offers into the result of offers available

ref: UXCT-193

Signed-off-by: Stephanie Moallic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants