-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pack.move): rework for pack move to add fiber offers #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steffy29
added
quality check
feature
New feature
universe-telecom
translation required
labels
Jun 16, 2020
marie-j
reviewed
Jun 18, 2020
...elecom/pack/migration/building-details/telecom-pack-migration-building-details.controller.js
Outdated
Show resolved
Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/move/address/future/move-address-future.html
Outdated
Show resolved
Hide resolved
Steffy29
force-pushed
the
feat/pack-xdsl-move-offers
branch
2 times, most recently
from
June 30, 2020 12:48
9a0e2b1
to
99de0b1
Compare
frenautvh
reviewed
Jul 2, 2020
packages/manager/apps/telecom/src/app/telecom/pack/move/address/move-address.controller.js
Outdated
Show resolved
Hide resolved
JeremyDec
reviewed
Jul 3, 2020
packages/manager/apps/telecom/src/app/telecom/pack/move/address/move-address.controller.js
Outdated
Show resolved
Hide resolved
.../apps/telecom/src/app/telecom/pack/move/building-details/move-building-details.controller.js
Outdated
Show resolved
Hide resolved
...s/manager/apps/telecom/src/app/telecom/pack/move/building-details/move-building-details.html
Outdated
Show resolved
Hide resolved
...ger/apps/telecom/src/app/telecom/pack/move/eligibility/address/move-eligibility-address.html
Outdated
Show resolved
Hide resolved
...ger/apps/telecom/src/app/telecom/pack/move/eligibility/address/move-eligibility-address.html
Show resolved
Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/move/eligibility/move-eligibility.html
Outdated
Show resolved
Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/move/meeting/move-meeting.html
Outdated
Show resolved
Hide resolved
Steffy29
force-pushed
the
feat/pack-xdsl-move-offers
branch
from
July 3, 2020 13:03
99de0b1
to
dc3a571
Compare
Steffy29
force-pushed
the
feat/pack-xdsl-move-offers
branch
from
July 22, 2020 15:33
4284242
to
5b656c0
Compare
JeremyDec
reviewed
Jul 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review due to the size of the PR
.../apps/telecom/src/app/telecom/pack/move/building-details/move-building-details.controller.js
Outdated
Show resolved
Hide resolved
.../apps/telecom/src/app/telecom/pack/move/building-details/move-building-details.controller.js
Outdated
Show resolved
Hide resolved
.../apps/telecom/src/app/telecom/pack/move/building-details/move-building-details.controller.js
Outdated
Show resolved
Hide resolved
...telecom/src/app/telecom/pack/move/eligibility/address/move-eligibility-address.controller.js
Outdated
Show resolved
Hide resolved
...telecom/src/app/telecom/pack/move/eligibility/address/move-eligibility-address.controller.js
Outdated
Show resolved
Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/move/offers/move-offers.controller.js
Show resolved
Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/move/offers/move-offers.controller.js
Outdated
Show resolved
Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/move/offers/move-offers.controller.js
Outdated
Show resolved
Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/move/offers/move-offers.html
Outdated
Show resolved
Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/move/offers/move-offers.html
Outdated
Show resolved
Hide resolved
Steffy29
force-pushed
the
feat/pack-xdsl-move-offers
branch
from
August 5, 2020 12:02
a50dfe5
to
ef39f1b
Compare
- Add the new eligibility search for copper and fiber offers - Add the fiber offers into the result of offers available ref: UXCT-193 Signed-off-by: Stephanie Moallic <[email protected]>
I'm rebasing this Pull Request on Thank you! |
antleblanc
force-pushed
the
feat/pack-xdsl-move-offers
branch
from
August 10, 2020 12:11
b51fff0
to
340ecab
Compare
Now rebased on |
antleblanc
approved these changes
Aug 10, 2020
radireddy
pushed a commit
that referenced
this pull request
Aug 19, 2020
- Add the new eligibility search for copper and fiber offers - Add the fiber offers into the result of offers available ref: UXCT-193 Signed-off-by: Stephanie Moallic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
develop
Description
🔗 Related