feat(telephony.portability): display uploaded files and more #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steffy29
added
quality check
feature
Steffy29
requested review from
antleblanc,
AxelPeter,
cbourgois,
FredericEspiau,
frenautvh,
ganeshkumar1989,
JeremyDec,
Jisay,
jleveugle,
lizardK,
marie-j,
radireddy and
varun257
as code owners
marie-j
reviewed
Dec 9, 2019
...m/src/app/telecom/telephony/alias/portability/portabilities/delete/portabilities-delete.html
Outdated
Show resolved
Hide resolved
...phony/alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.html
Outdated
Show resolved
Hide resolved
...phony/alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.html
Outdated
Show resolved
Hide resolved
...alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.routing.js
Outdated
Show resolved
Hide resolved
FredericEspiau
suggested changes
Dec 9, 2019
...as/portability/portabilities/telecom-telephony-alias-portability-portabilities.controller.js
Outdated
Show resolved
Hide resolved
...phony/alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.html
Outdated
Show resolved
Hide resolved
...phony/alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.html
Outdated
Show resolved
Hide resolved
...phony/alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.html
Outdated
Show resolved
Hide resolved
...alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.routing.js
Outdated
Show resolved
Hide resolved
...m/src/app/telecom/telephony/alias/portability/portabilities/delete/portabilities-delete.html
Outdated
Show resolved
Hide resolved
...app/telecom/telephony/alias/portability/portabilities/delete/portabilities-delete.routing.js
Outdated
Show resolved
Hide resolved
...phony/alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.html
Outdated
Show resolved
Hide resolved
|
Hi @Steffy29! We recently merged #1336 which apply Prettier rules so could you please rebase To easily resolve conflicts you can ignore After that you can run: $ yarn run lintThis command will lint the entire codebase. or: Amend your commit to trigger the Thanks! |
added 2 commits
January 7, 2020 10:28
delete files, upload more files than just one) Ref: UXCT-203 Signed-off-by: Stephanie Moallic <[email protected]>
Ref: UXCT-203 Signed-off-by: Stephanie Moallic <[email protected]>
Signed-off-by: Stephanie Moallic <[email protected]>
Signed-off-by: Stephanie Moallic <[email protected]>
antleblanc
force-pushed
the
feat/porta-hide-button-for-rio
branch
from
2abf843 to
f801c36
Compare
Signed-off-by: Stephanie Moallic <[email protected]>
antleblanc
requested changes
Jan 13, 2020
There was a problem hiding this comment.
@Steffy29 Sorry about the delay of reviewing this Pull Request but could you please address at least my comment related to the attribut type of the <button> element?
Thanks!
.../app/telecom/telephony/alias/portability/portabilities/delete/portabilities-delete.module.js
Outdated
Show resolved
Hide resolved
.../telecom/telephony/alias/portability/portabilities/delete/portabilities-delete.controller.js
Outdated
Show resolved
Hide resolved
...phony/alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.html
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephanie Moallic <[email protected]>
|
@antleblanc I correct the code from your comments. |
JeremyDec
reviewed
Jan 13, 2020
...m/src/app/telecom/telephony/alias/portability/portabilities/delete/portabilities-delete.html
Outdated
Show resolved
Hide resolved
...as/portability/portabilities/telecom-telephony-alias-portability-portabilities.controller.js
Outdated
Show resolved
Hide resolved
...phony/alias/portability/portabilities/telecom-telephony-alias-portability-portabilities.html
Show resolved
Hide resolved
Signed-off-by: Stephanie Moallic <[email protected]>
Steffy29
force-pushed
the
feat/porta-hide-button-for-rio
branch
from
7d80615 to
7f703ab
Compare
JeremyDec
approved these changes
Jan 13, 2020
antleblanc
reviewed
Jan 17, 2020
antleblanc
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Feature
feat(telephony.portability): display uploaded files, delete action available, authorize customer to upload another files until the portability is validated
🔗 Related
🏠 Internal
Ref: UXCT-203