Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCI Kubernetes: Get available flavors from API #1781

Merged
merged 2 commits into from
Nov 18, 2019
Merged

PCI Kubernetes: Get available flavors from API #1781

merged 2 commits into from
Nov 18, 2019

Conversation

marie-j
Copy link
Collaborator

@marie-j marie-j commented Nov 14, 2019 •
edited by antleblanc
Loading

@marie-j marie-j changed the title PCI Kubernetes: Get available flavors from APIé PCI Kubernetes: Get available flavors from API Nov 14, 2019
Jisay
Jisay previously approved these changes Nov 14, 2019
View reviewed changes
@antleblanc
Copy link
Member

@marie-j [email protected] has been released 🎉

antleblanc
antleblanc previously approved these changes Nov 14, 2019
View reviewed changes
@marie-j marie-j dismissed stale reviews from antleblanc and Jisay via 98017d9 November 14, 2019 16:20
antleblanc
antleblanc previously approved these changes Nov 14, 2019
View reviewed changes
@antleblanc
Copy link
Member

Hi @marie-j!

Could you please rebase your Pull Request on develop branch? (In conflict due to #1789)

Thanks!

FredericEspiau
FredericEspiau previously approved these changes Nov 18, 2019
View reviewed changes
packages/manager/apps/carrier-sip/package.json Outdated Show resolved Hide resolved
packages/manager/apps/cloud/package.json Outdated Show resolved Hide resolved
packages/manager/apps/dedicated/package.json Outdated Show resolved Hide resolved
packages/manager/apps/enterprise-cloud-database/package.json Outdated Show resolved Hide resolved
@marie-j
Copy link
Collaborator Author

marie-j commented Nov 18, 2019

Hi @marie-j!

Could you please rebase your Pull Request on develop branch? (In conflict due to #1789)

Thanks!

@antleblanc Done ! I've removed the commit responsible for the bump of ovh-api-services which was the one causing conflicts

@antleblanc antleblanc merged commit 444c53f into develop Nov 18, 2019
@antleblanc antleblanc deleted the feat/pci-kube-i1 branch November 18, 2019 13:26
@antleblanc antleblanc mentioned this pull request Nov 18, 2019
Merged
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antleblanc antleblanc antleblanc approved these changes

@FredericEspiau FredericEspiau FredericEspiau left review comments

@Jisay Jisay Jisay left review comments

@AxelPeter AxelPeter Awaiting requested review from AxelPeter

@cbourgois cbourgois Awaiting requested review from cbourgois

@euhmeuh euhmeuh Awaiting requested review from euhmeuh

@frenautvh frenautvh Awaiting requested review from frenautvh

@ganeshkumar1989 ganeshkumar1989 Awaiting requested review from ganeshkumar1989

@JeremyDec JeremyDec Awaiting requested review from JeremyDec

@jleveugle jleveugle Awaiting requested review from jleveugle

@lizardK lizardK Awaiting requested review from lizardK

@radireddy radireddy Awaiting requested review from radireddy

@varun257 varun257 Awaiting requested review from varun257

Assignees
No one assigned
Labels
feature New feature quality check: ok translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marie-j @antleblanc @Jisay @FredericEspiau