Telecom - Carrier SIP Trunk #1382

antleblanc · 2019-09-30T12:46:13Z

Carrier SIP Trunk

This feature lives into the Telecom Control Panel.

✨ Feature

ac07cbc - feat(carrier.sip): init module
f6ac48e - feat(carrier.sip): init application
588756d - feat(telephony.carrier.sip): add new module

🔗 Related

🇫🇷 https://www.ovhtelecom.fr/telephonie/carrier-sip-trunk/

🤝 Contributors

🏠 Internal

ref: MANAGER-3210

packages/manager/apps/carrier-sip/package.json

packages/manager/apps/carrier-sip/src/routing.js

packages/manager/apps/telecom/src/app/telecom/telephony/carrierSip/dashboard/cdr/cdr.routing.js

packages/manager/apps/telecom/webpack.config.js

packages/manager/modules/carrier-sip/src/carrier-sip.service.js

packages/manager/modules/carrier-sip/src/cdr/cdr.controller.js

marie-j · 2019-10-01T07:40:12Z

packages/manager/modules/carrier-sip/src/dashboard/index.scss

+  @import '~bootstrap4/scss/_grid';
+
+  .oui-page-header {
+    margin: 0 !important;


Should be a more specific selector if !important is needed

The actual one is linked to the component name (eg: carrier-sip-dashboard .oui-page-header).

Could you tell what you had in mind to tackle the !important flag? Because I'm not sure to understand which selector we can used here.

Actual selector that affect us is (from @ovh-ux/manager-telecom-styles):

:not(.widget-presentation) { header:not(.widget-presentation-header):not(.page-header) {

packages/manager/modules/carrier-sip/src/index.js

antleblanc · 2019-10-01T10:13:27Z

@marie-j Thanks! I've applied changes regarding your comments.
Feel free to tell me if that's looks good for you.

Regarding the comment for using Iceberg, I let @JeremyDec answer it.

Thanks!

FredericEspiau · 2019-10-02T07:14:34Z

packages/manager/modules/carrier-sip/src/index.js

@@ -0,0 +1,30 @@
+import angular from 'angular';
+
+// Peer dependencies.


I think comments should be used to say why you do something, not what you do, what do you think ? :)

I have added them to keep organized as much as possible in all imports.

Nothing blocker but yes we can find maybe a way to harmonize all imports.

IMO, comments to organize our code is still a nice things. It's not like it's comments that explain nothing like :

// Check if true if (foo === true) { }

If we need the same comments on 100 files, it probably means we need another solution than comments, like a coding convention :)

Or a tool that sort by itself :)

packages/manager/modules/carrier-sip/src/endpoints/index.js

packages/manager/modules/carrier-sip/src/endpoints/endpoints.html

packages/manager/modules/carrier-sip/src/dashboard/translations/Messages_fr_FR.json

packages/manager/modules/carrier-sip/src/cdr/translations/Messages_fr_FR.json

packages/manager/modules/carrier-sip/src/cdr/cdr.html

packages/manager/modules/carrier-sip/src/cdr/cdr.controller.js

packages/manager/modules/carrier-sip/src/cdr/cdr.constants.js

yarn.lock

antleblanc · 2019-10-07T13:11:43Z

Rebased on develop branch due to #1416.

FredericEspiau

Good job 👍

FredericEspiau · 2019-10-08T08:39:52Z

packages/manager/apps/carrier-sip/src/config.js

@@ -0,0 +1,8 @@
+export const momentConfiguration = /* @ngInject */ (TranslateServiceProvider) => {


Shouldn't this be done by the Core ?

IMO, Nope.
The core module provides a service to get the user locale, his goal is not to configure all dependencies that are used by some modules (even though moment is frequently used).

...s/manager/apps/telecom/src/components/telecom/telephony/sidebar/telephony-sidebar.service.js

packages/manager/modules/carrier-sip/src/carrier-sip.service.js

packages/manager/modules/carrier-sip/src/cdr/cdr.controller.js

FredericEspiau · 2019-10-08T08:53:34Z

packages/manager/modules/carrier-sip/src/cdr/translations/Messages_fr_FR.json

@@ -0,0 +1,11 @@
+{
+  "carrier_sip_cdr_title": "CDR",
+  "carrier_sip_cdr_information": "Le Call Details Records (CDR) contient toutes les informations relatives à un appel téléphonique : numéro de téléphone, durée d’appel, date et heure de l’appel, etc. Obtenez le détail des appels passés en téléchargeant le fichier .csv après avoir sélectionné la période souhaitée (mois et année) ci-dessous.",


Suggested change

"carrier_sip_cdr_information": "Le Call Details Records (CDR) contient toutes les informations relatives à un appel téléphonique : numéro de téléphone, durée d’appel, date et heure de l’appel, etc. Obtenez le détail des appels passés en téléchargeant le fichier .csv après avoir sélectionné la période souhaitée (mois et année) ci-dessous.",

"carrier_sip_cdr_information": "Le Call Details Records (CDR) contient toutes les informations relatives à un appel téléphonique : numéro de téléphone, durée d’appel, date et heure de l’appel, etc. Obtenez le détail des appels passés en téléchargeant le fichier .csv après avoir sélectionné la période souhaitée (mois et année) ci-dessous.",

insecable space 😅 don't worry about it

packages/manager/modules/carrier-sip/src/cdr/translations/Messages_fr_FR.json

packages/manager/modules/carrier-sip/src/dashboard/translations/Messages_fr_FR.json

packages/manager/modules/carrier-sip/src/endpoints/translations/Messages_fr_FR.json

ref: MANAGER-3210 Co-authored-by: Marie JONES <[email protected]> Co-authored-by: JeremyDec <[email protected]> BREAKING CHANGE: init `@ovh-ux/manager-carrier-sip` module.

ref: MANAGER-3210 Co-authored-by: Marie JONES <[email protected]> Co-authored-by: JeremyDec <[email protected]> BREAKING CHANGE: init `@ovh-ux/manager-carrier-sip-app` application.

ref: MANAGER-3210 Co-authored-by: Marie JONES <[email protected]> Co-authored-by: JeremyDec <[email protected]>

antleblanc added feature New feature universe-telecom labels Sep 30, 2019

antleblanc requested review from AxelPeter, cbourgois, euhmeuh, FredericEspiau, frenautvh, ganeshkumar1989, JeremyDec, Jisay, jleveugle, lizardK, marie-j, radireddy and varun257 as code owners September 30, 2019 12:46

antleblanc assigned antleblanc, marie-j and JeremyDec Sep 30, 2019

antleblanc force-pushed the feat/carrier-sip branch from db1a747 to 6fc531e Compare September 30, 2019 14:32

marie-j reviewed Oct 1, 2019

View reviewed changes

antleblanc changed the title ~~Feat/carrier sip~~ Telecom - Carrier SIP Trunk Oct 1, 2019

antleblanc force-pushed the feat/carrier-sip branch from 6fc531e to 34d1aa1 Compare October 1, 2019 10:02

antleblanc requested a review from marie-j October 1, 2019 10:10

JeremyDec force-pushed the feat/carrier-sip branch 3 times, most recently from 6b1e64b to 85fe745 Compare October 1, 2019 15:07

FredericEspiau suggested changes Oct 2, 2019

View reviewed changes

antleblanc force-pushed the feat/carrier-sip branch 2 times, most recently from 1d01dac to c2d4efe Compare October 2, 2019 09:02

JeremyDec force-pushed the feat/carrier-sip branch 2 times, most recently from 5c785ee to 1a4bbcd Compare October 2, 2019 09:38

antleblanc requested a review from FredericEspiau October 2, 2019 09:43

marie-j reviewed Oct 2, 2019

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

JeremyDec force-pushed the feat/carrier-sip branch from 1a4bbcd to 4b7046f Compare October 2, 2019 15:24

antleblanc force-pushed the feat/carrier-sip branch 2 times, most recently from 81e8db8 to c542e1e Compare October 3, 2019 08:22

antleblanc requested a review from marie-j October 3, 2019 08:22

antleblanc force-pushed the feat/carrier-sip branch from c542e1e to c6825b1 Compare October 4, 2019 12:28

antleblanc mentioned this pull request Oct 4, 2019

feat(pci): add stream product #1395

Merged

7 tasks

antleblanc force-pushed the feat/carrier-sip branch from c6825b1 to 0afb76a Compare October 7, 2019 13:10

AxelPeter previously approved these changes Oct 8, 2019

View reviewed changes

FredericEspiau previously approved these changes Oct 8, 2019

View reviewed changes

marie-j dismissed stale reviews from FredericEspiau and AxelPeter via 4d0ee68 October 8, 2019 14:46

marie-j force-pushed the feat/carrier-sip branch from 0afb76a to 4d0ee68 Compare October 8, 2019 14:46

antleblanc added the quality check label Oct 10, 2019

JeremyDec force-pushed the feat/carrier-sip branch from 4d0ee68 to e481bda Compare October 11, 2019 15:00

JeremyDec added quality check: ok and removed quality check labels Oct 14, 2019

antleblanc and others added 3 commits October 14, 2019 10:10

feat(carrier.sip): init module

ac07cbc

ref: MANAGER-3210 Co-authored-by: Marie JONES <[email protected]> Co-authored-by: JeremyDec <[email protected]> BREAKING CHANGE: init `@ovh-ux/manager-carrier-sip` module.

feat(carrier.sip): init application

f6ac48e

ref: MANAGER-3210 Co-authored-by: Marie JONES <[email protected]> Co-authored-by: JeremyDec <[email protected]> BREAKING CHANGE: init `@ovh-ux/manager-carrier-sip-app` application.

feat(telephony.carrier.sip): add new module

588756d

ref: MANAGER-3210 Co-authored-by: Marie JONES <[email protected]> Co-authored-by: JeremyDec <[email protected]>

JeremyDec force-pushed the feat/carrier-sip branch from e481bda to 588756d Compare October 14, 2019 08:14

Jisay approved these changes Oct 14, 2019

View reviewed changes

antleblanc merged commit 66bcfad into develop Oct 14, 2019

antleblanc deleted the feat/carrier-sip branch October 14, 2019 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Telecom - Carrier SIP Trunk #1382

Telecom - Carrier SIP Trunk #1382

antleblanc commented Sep 30, 2019 •

edited

Loading

marie-j Oct 1, 2019

antleblanc Oct 1, 2019 •

edited

Loading

antleblanc commented Oct 1, 2019

FredericEspiau Oct 2, 2019

antleblanc Oct 2, 2019

AxelPeter Oct 8, 2019

FredericEspiau Oct 8, 2019 •

edited

Loading

antleblanc commented Oct 7, 2019

FredericEspiau left a comment

FredericEspiau Oct 8, 2019

cbourgois Oct 8, 2019

FredericEspiau Oct 8, 2019

		@@ -0,0 +1,30 @@
		import angular from 'angular';

		// Peer dependencies.

		@@ -0,0 +1,8 @@
		export const momentConfiguration = /* @ngInject */ (TranslateServiceProvider) => {

	"carrier_sip_cdr_information": "Le Call Details Records (CDR) contient toutes les informations relatives à un appel téléphonique : numéro de téléphone, durée d’appel, date et heure de l’appel, etc. Obtenez le détail des appels passés en téléchargeant le fichier .csv après avoir sélectionné la période souhaitée (mois et année) ci-dessous.",
	"carrier_sip_cdr_information": "Le Call Details Records (CDR) contient toutes les informations relatives à un appel téléphonique : numéro de téléphone, durée d’appel, date et heure de l’appel, etc. Obtenez le détail des appels passés en téléchargeant le fichier .csv après avoir sélectionné la période souhaitée (mois et année) ci-dessous.",

Telecom - Carrier SIP Trunk #1382

Telecom - Carrier SIP Trunk #1382

Conversation

antleblanc commented Sep 30, 2019 • edited Loading

Carrier SIP Trunk

✨ Feature

🔗 Related

🤝 Contributors

🏠 Internal

marie-j Oct 1, 2019

Choose a reason for hiding this comment

antleblanc Oct 1, 2019 • edited Loading

Choose a reason for hiding this comment

antleblanc commented Oct 1, 2019

FredericEspiau Oct 2, 2019

Choose a reason for hiding this comment

antleblanc Oct 2, 2019

Choose a reason for hiding this comment

AxelPeter Oct 8, 2019

Choose a reason for hiding this comment

FredericEspiau Oct 8, 2019 • edited Loading

Choose a reason for hiding this comment

antleblanc commented Oct 7, 2019

FredericEspiau left a comment

Choose a reason for hiding this comment

FredericEspiau Oct 8, 2019

Choose a reason for hiding this comment

cbourgois Oct 8, 2019

Choose a reason for hiding this comment

FredericEspiau Oct 8, 2019

Choose a reason for hiding this comment

antleblanc commented Sep 30, 2019 •

edited

Loading

antleblanc Oct 1, 2019 •

edited

Loading

FredericEspiau Oct 8, 2019 •

edited

Loading