This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Feat/contact change #1356
Merged
Feat/contact change #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marie-j
requested review from
antleblanc,
AxelPeter,
cbourgois,
euhmeuh,
FredericEspiau,
frenautvh,
ganeshkumar1989,
JeremyDec,
Jisay,
jleveugle,
radireddy and
varun257
as code owners
JeremyDec
previously approved these changes
Aug 23, 2019
marie-j
force-pushed
the
feat/contact-change
branch
from
5860de2 to
e7f13a5
Compare
|
Edit: Content has been reviewed |
antleblanc
previously approved these changes
Aug 23, 2019
FredericEspiau
previously approved these changes
Aug 27, 2019
| this.OvhHttp = OvhHttp; | ||
| } | ||
|
|
||
| // TODO: Find a way to inject ovh-api-services depending on the service category |
There was a problem hiding this comment.
Looks like a good requirement for the successor of ovh-api-services, maybe you could add it to the document of requirements (ask JC for it as I don't know where it is :D)
|
|
||
| getServices() { | ||
| return this.OvhApiOvhProduct.Aapi().query().$promise | ||
| .then((services) => { |
There was a problem hiding this comment.
Suggested change
| .then((services) => { | |
| .then((services) => _.map( | |
| _.filter( | |
| services, | |
| service => AVAILABLE_SERVICES.includes(service.category), | |
| ), | |
| service => new BillingService(service), | |
| ) |
There was a problem hiding this comment.
Both solutions are correct. We can keep the default one.
client/app/account/contacts/service/edit/translations/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
client/app/account/contacts/service/edit/translations/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
client/app/account/contacts/service/edit/translations/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
client/app/account/contacts/service/translations/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
client/app/account/contacts/service/translations/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
client/app/account/contacts/service/translations/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
marie-j
force-pushed
the
feat/contact-change
branch
from
fef154a to
25695fd
Compare
antleblanc
previously approved these changes
Aug 28, 2019
marie-j
force-pushed
the
feat/contact-change
branch
from
25695fd to
4c74255
Compare
|
Hello @marie-j, |
marie-j
force-pushed
the
feat/contact-change
branch
from
4c74255 to
15fe69a
Compare
marie-j
force-pushed
the
feat/contact-change
branch
from
15fe69a to
4030423
Compare
frenautvh
previously approved these changes
Sep 16, 2019
FredericEspiau
previously approved these changes
Sep 17, 2019
client/app/account/contacts/service/translations/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
client/app/account/contacts/service/translations/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
cbourgois
reviewed
Sep 17, 2019
cbourgois
previously approved these changes
Sep 17, 2019
marie-j
dismissed stale reviews from cbourgois, FredericEspiau, and frenautvh
via
7c7d5fe
marie-j
force-pushed
the
feat/contact-change
branch
from
4030423 to
7c7d5fe
Compare
antleblanc
approved these changes
Sep 19, 2019
|
|
||
| getServices() { | ||
| return this.OvhApiOvhProduct.Aapi().query().$promise | ||
| .then((services) => { |
There was a problem hiding this comment.
Both solutions are correct. We can keep the default one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent billing contact changes for services with a debt
Description of the Change
MBE-269
Related