This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
Feat/data processing #286
Merged
Feat/data processing #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2020 11:40
Signed-off-by: hlarcher <[email protected]>
Signed-off-by: hlarcher <[email protected]>
Hugoch
requested review from
antleblanc,
AxelPeter,
cbourgois,
FredericEspiau,
frenautvh,
ganeshkumar1989,
JeremyDec,
Jisay,
jleveugle,
lizardK,
marie-j,
radireddy and
varun257
as code owners
antleblanc
suggested changes
Mar 3, 2020
There was a problem hiding this comment.
Thanks @Hugoch!
To keep consistency with naming convention I suggested some changes.
I've also mentioned if some transformResponse can be removed.
Thanks!
src/api/cloud/project/dataprocessing/cloud-project-dataprocessing.v6.service.js
Outdated
Show resolved
Hide resolved
...t/dataprocessing/authorization/cloud-project-dataprocessing-authorization.iceberg.service.js
Show resolved
Hide resolved
src/api/cloud/project/dataprocessing/jobs/cloud-project-dataprocessing-jobs.iceberg.service.js
Show resolved
Hide resolved
Signed-off-by: hlarcher <[email protected]>
antleblanc
approved these changes
Mar 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add API routes for new beta Data Processing product