This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
feat: add OLA group/ungroup endpoints #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizardK
approved these changes
Sep 25, 2019
JeremyDec
reviewed
Sep 25, 2019
| group: { | ||
| url: '/dedicated/server/:serverName/ola/group', | ||
| method: 'POST', | ||
| data: { |
There was a problem hiding this comment.
I see data for some routes, and paramsfor other, there is a reason ? (data doesn't exists for $resource if we refer to documentation : https://docs.angularjs.org/api/ngResource/service/$resource#$resource-arguments)
There was a problem hiding this comment.
params is for URI parameters, while data is for body parameters. But maybe the documentation I saw was deprecated, and data is no longer useful... Anyways it works as is and provides a great documentation about what's expected.
There was a problem hiding this comment.
yes, this is not useful anymore
FredericEspiau
approved these changes
Sep 26, 2019
JeremyDec
approved these changes
Sep 26, 2019
Jisay
approved these changes
Sep 26, 2019
cbourgois
approved these changes
Sep 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MANAGER-3148