Feat/resolve stats #883
Merged
Feat/resolve stats #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ciaranschutte
commented
Aug 14, 2024
•
ciaranschutte
commented
- resolve network aggregation from multiple single network aggs
- Aggregations => NetworkAggregation
- unit tests
- not all properties covered, just the minimal buckets for now
ciaranschutte
changed the base branch from
develop
to
feature/federated_search
added 2 commits
August 13, 2024 22:52
demariadaniel
approved these changes
Aug 14, 2024
| @@ -1,2 +1,51 @@ | |||
| import { SupportedAggregation, SUPPORTED_AGGREGATIONS } from '../common'; | |||
| import { Aggregations, NetworkAggregation, NumericAggregations } from '../types'; | |||
|
|
|||
| // TODO: implement | |||
| export const resolveAggregations = (networkResults: void) => null; | |||
There was a problem hiding this comment.
When you get around to working on this function I'd update this name. I'd add something descriptive to distinguish it's purpose from resolveAggregation
| @@ -0,0 +1,27 @@ | |||
| import { resolveAggregation } from '..'; | |||
| import { aggregation } from './fixture'; | |||
There was a problem hiding this comment.
Why fixture, isn't stubs the more common name for test data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.