Remove legacy deposit/withdrawal in Electra #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rationale: Best way to avoid crashing
gazzua
reviewed
Oct 31, 2024
| @@ -0,0 +1,130 @@ | |||
| # Enable Powerlevel10k instant prompt. Should stay close to the top of ~/.zshrc. | |||
There was a problem hiding this comment.
i think you committed wrong file 😄
gazzua
reviewed
Oct 31, 2024
| @@ -0,0 +1,487 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
gazzua
reviewed
Oct 31, 2024
| @@ -0,0 +1,340 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
There was a problem hiding this comment.
committed wrong file. sync committee is deleted in other pr
|
add state version check would be better at |
gazzua
reviewed
Oct 31, 2024
| @@ -57,7 +57,6 @@ type BeaconState struct { | |||
| nextWithdrawalValidatorIndex primitives.ValidatorIndex | |||
|
|
|||
| // Electra fields | |||
| depositRequestsStartIndex uint64 | |||
| depositBalanceToConsume primitives.Gwei | |||
There was a problem hiding this comment.
DepositRequestsStartIndex in beaconStateMarshalable should also be removed.
|
Closed due to a change of plan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove legacy deposit/withdrawal from Electra
Temporarily commented out tests