-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert change that skip arm64 image build #47
Conversation
- As didkit issue is resolved in latest version which is being used in upstream credential repo. So, reverting this change. for context, see this comment: #34 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! You want to make a new release to try out the arm64 CI pipeline? When you do, you'll realize that we need a changelog entry, so we might just as well add one here, despite the fact that it's "just" a CI change.
The upstream fix (via requirements upgrade) was merged into master and not backported to redwood.master. Therefore, only the nightly build is working. The master build is still broken. We have 2 options here:
|
I have created the backport PR. So that it can work with redwood. |
I realized later that merging to redwood.master is not enough. We would need to wait for redwood.3 tag to be available for the build to pass. I am not sure if Axim has redwood.3 tag planned in near future. |
I think we can merge this change in nightly then. |
The release of redwood.3 is planned for 23 Oct. |
78c80be
to
7a44277
Compare
We'll be merging back this feature in sumac in favor of this info. |
For context, see this comment: tutor-credentials codebase Python 3.11 upgrade #34 (comment)